Modified code in src/topics to allow users to mark a question as "Good." #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Code is well formatted! Maybe add some comments. |
|
Looks good, I agree with Jackson though - having comments would help the rest of us contribute later |
arjuanwall
force-pushed
the
markQuestionAsGood
branch
from
0c57c00 to
8d6a5a3
Compare
Pull Request Test Coverage Report for Build 13578493723Details
💛 - Coveralls |
phiofuni
reviewed
Feb 27, 2025
| @@ -116,6 +116,28 @@ module.exports = function (Posts) { | |||
| } | |||
| } | |||
|
|
|||
| Posts.goodquestion = async function (pid, uid) { | |||
There was a problem hiding this comment.
It's better to make a comment here to explain what the Posts.goodquestion do?
nodebb-theme-harmony/scss/topic.scss
Outdated
| [component="post/upvote"], | ||
| [component="post/downvote"], | ||
| [component="post/goodquestion"] { | ||
|
|
| @@ -6,7 +6,7 @@ | |||
| "group-privileges": "Group Privileges", | |||
| "user-privileges": "User Privileges", | |||
| "edit-privileges": "Edit Privileges", | |||
| "select-clear-all": "Select/Clear All", | |||
| "select-clear-all": "Select/Clear All", | |||
There was a problem hiding this comment.
could probably mimic these changes in the en-UK version of the .json too
eenkhbol
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files edited:
nodebb-theme-harmony/scss/topic.scss - Added the post/goodquestion topic.
nodebb-theme-harmony/templates/partials/topic/post.tpl - Added the good question button on the front-end.
public/language/en-US/admin/manage/privileges.json and public/language/en-US/topic.json - Added button name.
src/posts/votes.js - Added the ability to mark the question as Good as a function.
src/privileges/topics.js, src/upgrades/1.7.4/vote_privilege.js - Give users admin access to mark a question as Good.
test/goodQuestion.js - Added comprehensive testing for this feature (marking, unmarking).
Feature was tested by running npm run lint and test to ensure that this did not break any other functionality in NodeBB.
Resolves #2