Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added composer category selector #43

Merged
merged 2 commits into from
Feb 27, 2025
Merged

feat: added composer category selector #43

merged 2 commits into from
Feb 27, 2025

Conversation

ethan1696
Copy link
Contributor

@ethan1696 ethan1696 commented Feb 26, 2025

This PR changes the category selector in the composer when posting a topic. It changes it to use checkboxes so a post can be made to multiple categories at once.

image

This addresses #22 and #23

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13552409986

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 82.676%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 13552322057: -0.005%
Covered Lines: 22353
Relevant Lines: 25615

💛 - Coveralls

@ethan1696 ethan1696 changed the title Category selector feat: added composer category selector Feb 26, 2025
@ethan1696 ethan1696 self-assigned this Feb 27, 2025
Copy link
Contributor

@kzhang31415 kzhang31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but do you think the plugin can be added as a dependency rather than directly to the code base?

@ethan1696
Copy link
Contributor Author

Looks good, but do you think the plugin can be added as a dependency rather than directly to the code base?

Yes, the plugin is already a dependency.

@ethan1696 ethan1696 merged commit 1f1e17c into main Feb 27, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants