-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field to specify whether a dataset can be downloaded using datalad #885
Comments
Edit: for consistency with general practice, the field name should be |
The current download options are:
|
Thinking about this, it seems to me that the default display of buttons should match with the most restrictive option we provide, which in this case is "Offsite only", so that any errors here have the failure mode of being overly restrictive rather than releasing (or appearing to release) data more widely than we should. Having the interface read a |
A first test entry for |
Proposed refinements of the categorisation laid out by @GHPBZ above, based on recent meeting: "Direct download" and "datalad download" categories are exactly the same right now, so can be treated as a single category. The desired logic is as follows: IF This separates datasets into clearly defined categories based on information already stored in the DATS.json file so avoids the issue of asking users to explicitly specify something fiddly and non-intuitive to control the button attached to their datasets Suggestions for the "other options" above include checks to identify braincode and eegnet data. We could identify each of these by looking for a matching string in the name or source URL of the dataset; like the condition for "loris", this will want close monitoring. |
Note from this morning's CONP dev meeting; a case has arisen which our current setup does not well handle, which is that of connecting to an offsite dataset with no login needed. Design for this TBD. |
This issue proposes the addition of a new field to the
extraProperties
section of the CONP DATS.json file, nameddownload_options
. This field will indicate whether it is possible to download the dataset in question by the default datalad procedure as documented in the CONP interface page, and be used to determine which of the current "Direct download", "Download with Datalad" and "Third-party account required" buttons/links on the right-hand side of the dataset card are displayed and/or emphasised. Suggestions and other feedback welcome, this is very much an opening draft.Suggested behaviour:
extraProperties
=>download_options
entry, the dataset card should be displayed as it is currently.download_option
field could equally well support multiple values, to facilitate multiple alternative download button layouts. Is this an option we want to consider at this time?Implementation:
Once the questions raised above are addressed to the point of implementing a prototype, this functionality calls for:
download_options
entry (such as OBI data.) A couple of these can be done quickly for initial test purposes to allow the other steps to proceed in parallel (Emmet).download_options
value is read. (Laetitia)download_options
value (Alexandre) and come up with a clear and concise description of what it is for and when/why/how it should be filled in. (Patrick) Radio buttons or a pull-down list seem like workable options here.The text was updated successfully, but these errors were encountered: