Skip to content

Commit c4def12

Browse files
committed
Small code modernizations
- Use std::numeric_limits<uid_t>::max() to ensure consistency with gui/gid - Specify partition_id_t as a constexpr
1 parent ade0d62 commit c4def12

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

implementation/configuration/include/internal.hpp.in

+3-3
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,8 @@ inline constexpr std::uint32_t MAX_RECONNECTS_UNLIMITED = (std::numeric_limits<s
160160
inline constexpr std::uint32_t MAX_RECONNECTS_LOCAL_UDS = 13;
161161
inline constexpr std::uint32_t MAX_RECONNECTS_LOCAL_TCP = 5;
162162

163-
const uid_t ANY_UID = 0xFFFFFFFF;
164-
const gid_t ANY_GID = 0xFFFFFFFF;
163+
inline constexpr uid_t ANY_UID = std::numeric_limits<uid_t>::max();
164+
inline constexpr gid_t ANY_GID = std::numeric_limits<uid_t>::max();
165165

166166
enum class port_type_e {
167167
PT_OPTIONAL,
@@ -171,7 +171,7 @@ enum class port_type_e {
171171
};
172172

173173
using partition_id_t = std::uint8_t;
174-
const partition_id_t VSOMEIP_DEFAULT_PARTITION_ID = 0;
174+
inline constexpr partition_id_t VSOMEIP_DEFAULT_PARTITION_ID = 0;
175175

176176
} // namespace vsomeip_v3
177177

test/unit_tests/security_tests/ut_is_client_allowed.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ namespace {
2222

2323
vsomeip_v3::gid_t invalid_uid = 1;
2424
vsomeip_v3::gid_t invalid_gid = 1;
25-
vsomeip_v3::uid_t ANY_UID = 0xFFFFFFFF;
26-
vsomeip_v3::gid_t ANY_GID = 0xFFFFFFFF;
25+
vsomeip_v3::uid_t ANY_UID = std::numeric_limits<uid_t>::max();
26+
vsomeip_v3::gid_t ANY_GID = std::numeric_limits<uid_t>::max();
2727

2828
vsomeip_v3::gid_t deny_uid = 9999;
2929
vsomeip_v3::gid_t deny_gid = 9999;

0 commit comments

Comments
 (0)