Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jupyter Notebooks #440

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Fix Jupyter Notebooks #440

merged 5 commits into from
Jan 23, 2025

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Jan 20, 2025 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Addresses an issue with some notebooks failing to build against the latest PAVICS alpha image

Does this PR introduce a breaking change?

Not yet.

Other information:

Private issue: https://github.com/Ouranosinc/pavics-jupyter-env-issues/issues/18

@Zeitsperre
synchronize dependencies
746fe82 
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@github-actions github-actions bot added the docs label Jan 20, 2025
@coveralls
Copy link

coveralls commented Jan 20, 2025 •
edited
Loading

Coverage Status

coverage: 81.292%. remained the same
when pulling 9c718bb on fix-notebooks-xarray
into 0547d11 on master.

@Zeitsperre
unpin intake
07a8e18 
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
tlvu
tlvu reviewed Jan 20, 2025
View reviewed changes
@Zeitsperre Zeitsperre marked this pull request as ready for review January 23, 2025 18:54
tlvu
tlvu approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zeitsperre Zeitsperre merged commit b920118 into master Jan 23, 2025
14 checks passed
@Zeitsperre Zeitsperre deleted the fix-notebooks-xarray branch January 23, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlvu tlvu tlvu approved these changes

Assignees

@Zeitsperre Zeitsperre

@tlvu tlvu

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @coveralls @tlvu