Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hindcast notebook #463

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix hindcast notebook #463

merged 2 commits into from
Feb 25, 2025

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Feb 25, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Fixes an API issue in Comparing_hindcasts_and_ESP_forecasts.ipynb

Does this PR introduce a breaking change?

No.

@Zeitsperre Zeitsperre requested a review from tlvu February 25, 2025 18:13
@Zeitsperre Zeitsperre self-assigned this Feb 25, 2025
@github-actions github-actions bot added the docs label Feb 25, 2025
@coveralls
Copy link

coveralls commented Feb 25, 2025

Coverage Status

coverage: 82.055% (+0.02%) from 82.032%
when pulling 0adc922 on fix-pjei-19
into 2f58b6a on master.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Jenkins in prod and vs py3.12, this works.

So finally the fix is in the notebook and a ravenpy release was not required at all, since it works again in prod without new ravenpy?

@Zeitsperre
Copy link
Member Author

So finally the fix is in the notebook and a ravenpy release was not required at all, since it works again in prod without new ravenpy?

I suppose not. We need a release anyway, but we can now wait a few weeks for the new features to get support. Glad things are working!

@Zeitsperre Zeitsperre merged commit 6dbfb8b into master Feb 25, 2025
17 checks passed
@Zeitsperre Zeitsperre deleted the fix-pjei-19 branch February 25, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants