Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write to local disk in notebook 00 #465

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

Zeitsperre
Copy link
Member

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Slightly modified 00_Introduction_to_JupyterLab.ipynb to not write to disk.

Does this PR introduce a breaking change?

Not in my opinion. The example Markdown has been modified to suggest that users can write to their workspaces by modifying the example.

@Zeitsperre Zeitsperre requested review from huard and tlvu February 26, 2025 21:02
@Zeitsperre Zeitsperre self-assigned this Feb 26, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the docs label Feb 26, 2025
@coveralls
Copy link

Coverage Status

coverage: 82.055%. remained the same
when pulling 9a6ae9f on fix-pjeiv-23
into 97e5163 on master.

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB pass in a read-only current dir now, thanks.

@Zeitsperre Zeitsperre merged commit 425a88c into master Feb 26, 2025
18 checks passed
@Zeitsperre Zeitsperre deleted the fix-pjeiv-23 branch February 26, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants