Skip to content

Added Lint Check to CI #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Added Lint Check to CI #487

merged 4 commits into from
Feb 14, 2025

Conversation

jmwright
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 86.78571% with 74 lines in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (6c6e322) to head (fff414d).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
cq_editor/preferences.py 28.57% 15 Missing ⚠️
cq_editor/utils.py 72.97% 6 Missing and 4 partials ⚠️
cq_editor/widgets/debugger.py 90.00% 7 Missing and 1 partial ⚠️
cq_editor/widgets/viewer.py 87.30% 6 Missing and 2 partials ⚠️
cq_editor/widgets/editor.py 86.36% 2 Missing and 4 partials ⚠️
cq_editor/widgets/occt_widget.py 73.68% 5 Missing ⚠️
cq_editor/cq_utils.py 88.57% 3 Missing and 1 partial ⚠️
cq_editor/main_window.py 95.29% 4 Missing ⚠️
cq_editor/cqe_run.py 0.00% 3 Missing ⚠️
cq_editor/mixins.py 86.95% 2 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   88.59%   88.08%   -0.52%     
==========================================
  Files          20       20              
  Lines        1614     1628      +14     
  Branches      161      172      +11     
==========================================
+ Hits         1430     1434       +4     
- Misses        153      159       +6     
- Partials       31       35       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmwright
Copy link
Member Author

CI lint check is in place and linting has been done on the code base. This is going to cause issues with the outstanding PRs, but most of those are going to have to be reworked and/or merged piecemeal anyway. I'm going to merge and get it over with.

@jmwright jmwright merged commit 8c2d52a into master Feb 14, 2025
9 of 11 checks passed
@jmwright jmwright deleted the lint-ci branch February 14, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant