Skip to content

Resolve real path to the executable #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

nohal
Copy link
Contributor

@nohal nohal commented Mar 15, 2025

The run.sh scripts assumes it is in the current working directory and fails to actually start the bin/cq-editor binary if it is not so, making the $HOME/cq-editor/run.sh suggested as the start command in https://cadquery.readthedocs.io/en/latest/installation.html#adding-a-nicer-gui-via-cq-editor fail.

Resolving the actual location of the script and using it to start the binary fixes the problem.

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.20%. Comparing base (ffdcc3e) to head (23fd09f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #505   +/-   ##
=======================================
  Coverage   88.20%   88.20%           
=======================================
  Files          20       20           
  Lines        1712     1712           
  Branches      182      182           
=======================================
  Hits         1510     1510           
  Misses        163      163           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmwright
Copy link
Member

Thanks @nohal !

@jmwright jmwright merged commit 27f0984 into CadQuery:master Mar 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants