Move experimental.spawning to minimal_nonvanilla.spawning

Author: 2No2Name

common/src/main/java/net/caffeinemc/mods/lithium/mixin/experimental/spawning/package-info.java

@@ -1,4 +1,4 @@
-package net.caffeinemc.mods.lithium.mixin.experimental.spawning;
+package net.caffeinemc.mods.lithium.mixin.minimal_nonvanilla.spawning;
 
 import net.minecraft.util.ClassInstanceMultiMap;
 import net.minecraft.world.level.entity.EntitySection;

common/src/main/java/net/caffeinemc/mods/lithium/mixin/experimental/spawning/EntitySectionAccessor.java renamed to common/src/main/java/net/caffeinemc/mods/lithium/mixin/minimal_nonvanilla/spawning/EntitySectionAccessor.java

@@ -1,4 +1,4 @@
-package net.caffeinemc.mods.lithium.mixin.experimental.spawning;
+package net.caffeinemc.mods.lithium.mixin.minimal_nonvanilla.spawning;
 
 import com.google.common.collect.AbstractIterator;
 import it.unimi.dsi.fastutil.longs.Long2ObjectMap;

common/src/main/java/net/caffeinemc/mods/lithium/mixin/experimental/spawning/EntitySectionStorageMixin.java renamed to common/src/main/java/net/caffeinemc/mods/lithium/mixin/minimal_nonvanilla/spawning/EntitySectionStorageMixin.java

@@ -1,4 +1,4 @@
-package net.caffeinemc.mods.lithium.mixin.experimental.spawning;
+package net.caffeinemc.mods.lithium.mixin.minimal_nonvanilla.spawning;
 
 import net.minecraft.world.level.entity.EntityAccess;
 import net.minecraft.world.level.entity.EntitySectionStorage;

common/src/main/java/net/caffeinemc/mods/lithium/mixin/experimental/spawning/PersistentEntitySectionManagerAccessor.java renamed to common/src/main/java/net/caffeinemc/mods/lithium/mixin/minimal_nonvanilla/spawning/PersistentEntitySectionManagerAccessor.java

@@ -1,4 +1,4 @@
-package net.caffeinemc.mods.lithium.mixin.experimental.spawning;
+package net.caffeinemc.mods.lithium.mixin.minimal_nonvanilla.spawning;
 
 import net.caffeinemc.mods.lithium.common.world.ChunkAwareEntityIterable;
 import net.minecraft.server.level.ServerChunkCache;

common/src/main/java/net/caffeinemc/mods/lithium/mixin/experimental/spawning/ServerChunkCacheMixin.java renamed to common/src/main/java/net/caffeinemc/mods/lithium/mixin/minimal_nonvanilla/spawning/ServerChunkCacheMixin.java

@@ -1,4 +1,4 @@
-package net.caffeinemc.mods.lithium.mixin.experimental.spawning;
+package net.caffeinemc.mods.lithium.mixin.minimal_nonvanilla.spawning;
 
 import net.minecraft.server.level.ServerLevel;
 import net.minecraft.world.entity.Entity;

common/src/main/java/net/caffeinemc/mods/lithium/mixin/experimental/spawning/ServerLevelAccessor.java renamed to common/src/main/java/net/caffeinemc/mods/lithium/mixin/minimal_nonvanilla/spawning/ServerLevelAccessor.java

@@ -0,0 +1,8 @@
+@MixinConfigOption(
+        description = "Optimizations to spawning conditions. Reorders the iteration over entities to match the chunks " +
+                "and chunk sections, reducing the number of cache misses. Might differ slightly from vanilla due to " +
+                "floating point associativity differences when summing the spawning potential of density controlled " +
+                "spawns, e.g. skeleton, ghast, enderman and strider spawns in certain nether biomes.")
+package net.caffeinemc.mods.lithium.mixin.minimal_nonvanilla.spawning;
+
+import net.caffeinemc.gradle.MixinConfigOption;

common/src/main/java/net/caffeinemc/mods/lithium/mixin/minimal_nonvanilla/spawning/package-info.java

@@ -143,11 +143,6 @@
     "experimental.entity.block_caching.fire_lava_touching.EntityMixin",
     "experimental.entity.block_caching.suffocation.EntityMixin",
     "experimental.entity.item_entity_merging.ItemEntityMixin",
-    "experimental.spawning.EntitySectionAccessor",
-    "experimental.spawning.EntitySectionStorageMixin",
-    "experimental.spawning.PersistentEntitySectionManagerAccessor",
-    "experimental.spawning.ServerChunkCacheMixin",
-    "experimental.spawning.ServerLevelAccessor",
     "gen.cached_generator_settings.NoiseBasedChunkGeneratorMixin",
     "math.fast_blockpos.BlockPosMixin",
     "math.fast_blockpos.DirectionMixin",
@@ -160,6 +155,11 @@
     "minimal_nonvanilla.collisions.empty_space.ArrayVoxelShapeInvoker",
     "minimal_nonvanilla.collisions.empty_space.BitSetDiscreteVoxelShapeAccessor",
     "minimal_nonvanilla.collisions.empty_space.LevelMixin",
+    "minimal_nonvanilla.spawning.EntitySectionAccessor",
+    "minimal_nonvanilla.spawning.EntitySectionStorageMixin",
+    "minimal_nonvanilla.spawning.PersistentEntitySectionManagerAccessor",
+    "minimal_nonvanilla.spawning.ServerChunkCacheMixin",
+    "minimal_nonvanilla.spawning.ServerLevelAccessor",
     "minimal_nonvanilla.world.block_entity_ticking.support_cache.BlockEntityMixin",
     "minimal_nonvanilla.world.block_entity_ticking.support_cache.DirectBlockEntityTickInvokerMixin",
     "minimal_nonvanilla.world.block_entity_ticking.support_cache.LevelChunkMixin",

common/src/main/resources/lithium.mixins.json

@@ -406,10 +406,6 @@ Requirements:
 - `mixin.util.entity_collection_replacement=true`
 - `mixin.util.item_component_and_count_tracking=true`  
 
-### `mixin.experimental.spawning`
-(default: `true`)  
-Experimental optimizations to spawning conditions. Reorders the iteration over entities to match the chunks and chunk sections, reducing the number of cache misses.
-  
 ### `mixin.gen`
 (default: `true`)  
 Various world generation optimizations
@@ -454,6 +450,10 @@ Speed up frog attackable sensor by checking entity type before visibility test.
 (default: `true`)  
 Speed up finding empty spaces mobs fit into. This speeds up entity pose checks and nether portal positioning for colliding mobs (This code is vanilla's nether portal horse suffocation fix). If certain block collision surfaces have coordinates that are different but within 1e-7 of each other, this optimization may cause entities coming from nether portals or changing pose to be placed in a different position or pose than vanilla. This effect only occurs when the decision whether the entity fits into a space depends on a difference in the magnitude of 1e-7 blocks.
 
+### `mixin.minimal_nonvanilla.spawning`
+(default: `true`)  
+Optimizations to spawning conditions. Reorders the iteration over entities to match the chunks and chunk sections, reducing the number of cache misses. Might differ slightly from vanilla due to floating point associativity differences when summing the spawning potential of density controlled spawns, e.g. skeleton, ghast, enderman and strider spawns in certain nether biomes.
+  
 ### `mixin.minimal_nonvanilla.world.block_entity_ticking.support_cache`
 (default: `true`)  
 BlockEntity ticking caches whether the BlockEntity can exist in the BlockState at the same location. This deviates from vanilla in the case of placing a hopper in a powered location, immediately updating the cached BlockState (which is incorrect in vanilla). This most likely does not affect your gameplay, as this deviation only affects hoppers, and in vanilla, hoppers never use the cached state information anyway.  

lithium-fabric-mixin-config.md

@@ -379,10 +379,6 @@ Requirements:
 - `mixin.util.entity_collection_replacement=true`
 - `mixin.util.item_component_and_count_tracking=true`  
 
-### `mixin.experimental.spawning`
-(default: `true`)  
-Experimental optimizations to spawning conditions. Reorders the iteration over entities to match the chunks and chunk sections, reducing the number of cache misses.
-  
 ### `mixin.gen`
 (default: `true`)  
 Various world generation optimizations
@@ -427,6 +423,10 @@ Speed up frog attackable sensor by checking entity type before visibility test.
 (default: `true`)  
 Speed up finding empty spaces mobs fit into. This speeds up entity pose checks and nether portal positioning for colliding mobs (This code is vanilla's nether portal horse suffocation fix). If certain block collision surfaces have coordinates that are different but within 1e-7 of each other, this optimization may cause entities coming from nether portals or changing pose to be placed in a different position or pose than vanilla. This effect only occurs when the decision whether the entity fits into a space depends on a difference in the magnitude of 1e-7 blocks.
 
+### `mixin.minimal_nonvanilla.spawning`
+(default: `true`)  
+Optimizations to spawning conditions. Reorders the iteration over entities to match the chunks and chunk sections, reducing the number of cache misses. Might differ slightly from vanilla due to floating point associativity differences when summing the spawning potential of density controlled spawns, e.g. skeleton, ghast, enderman and strider spawns in certain nether biomes.
+  
 ### `mixin.minimal_nonvanilla.world.block_entity_ticking.support_cache`
 (default: `true`)  
 BlockEntity ticking caches whether the BlockEntity can exist in the BlockState at the same location. This deviates from vanilla in the case of placing a hopper in a powered location, immediately updating the cached BlockState (which is incorrect in vanilla). This most likely does not affect your gameplay, as this deviation only affects hoppers, and in vanilla, hoppers never use the cached state information anyway.