[Feature](bangc-ops): change the type of opt_boundary to int32 in mutual_information_forward and mutual_information_backward op #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual_information_forward and mutual_information_backward op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Motivation
change the type of opt_boundary to int32 in mutual_information_forward and mutual_information_backward op
2. Modification
modified: bangc-ops/kernels/mutual_information_backward/mutual_information_backward.cpp
bangc-ops/kernels/mutual_information_backward/mutual_information_backward_block.mlu
bangc-ops/kernels/mutual_information_forward/mutual_information_forward.cpp
bangc-ops/kernels/mutual_information_forward/mutual_information_forward_block.mlu
bangc-ops/test/mlu_op_gtest/pb_gtest/mlu_op_test_proto
bangc-ops/test/mlu_op_gtest/pb_gtest/src/zoo/mutual_information_backward/mutual_information_backward.cpp
bangc-ops/test/mlu_op_gtest/pb_gtest/src/zoo/mutual_information_backward/test_case/mutual_information_backward.prototxt
bangc-ops/test/mlu_op_gtest/pb_gtest/src/zoo/mutual_information_forward/mutual_information_forward.cpp
bangc-ops/test/mlu_op_gtest/pb_gtest/src/zoo/mutual_information_forward/test_case/mutual_information_forward.prototxt
docs/bangc-docs/design_docs/mutual_information_backward/mutual_information_backward.md
docs/bangc-docs/design_docs/mutual_information_forward/mutual_information_forward.md
3. Test Report
--enable-bang-memcheck: no warning or error
Platform : MLU370
[==========] 24 test cases from 1 test suite ran. (2700 ms total)
[ PASSED ] 12 test cases.
[ FAILED ] 12 test cases, listed below:
[ FAILED ] mutual_information_backward/TestSuite.mluOp/1, where GetParam() = ("mutual_information_backward", 1)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/3, where GetParam() = ("mutual_information_backward", 3)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/4, where GetParam() = ("mutual_information_backward", 4)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/5, where GetParam() = ("mutual_information_backward", 5)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/8, where GetParam() = ("mutual_information_backward", 8)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/9, where GetParam() = ("mutual_information_backward", 9)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/12, where GetParam() = ("mutual_information_backward", 12)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/14, where GetParam() = ("mutual_information_backward", 14)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/15, where GetParam() = ("mutual_information_backward", 15)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/17, where GetParam() = ("mutual_information_backward", 17)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/21, where GetParam() = ("mutual_information_backward", 21)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/22, where GetParam() = ("mutual_information_backward", 22)
12 FAILED TESTS
Platform : MLU590
[==========] 24 test cases from 1 test suite ran. (2700 ms total)
[ PASSED ] 12 test cases.
[ FAILED ] 12 test cases, listed below:
[ FAILED ] mutual_information_backward/TestSuite.mluOp/1, where GetParam() = ("mutual_information_backward", 1)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/3, where GetParam() = ("mutual_information_backward", 3)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/4, where GetParam() = ("mutual_information_backward", 4)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/5, where GetParam() = ("mutual_information_backward", 5)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/8, where GetParam() = ("mutual_information_backward", 8)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/9, where GetParam() = ("mutual_information_backward", 9)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/12, where GetParam() = ("mutual_information_backward", 12)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/14, where GetParam() = ("mutual_information_backward", 14)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/15, where GetParam() = ("mutual_information_backward", 15)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/17, where GetParam() = ("mutual_information_backward", 17)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/21, where GetParam() = ("mutual_information_backward", 21)
[ FAILED ] mutual_information_backward/TestSuite.mluOp/22, where GetParam() = ("mutual_information_backward", 22)
12 FAILED TESTS
3.4 Summary Analysis
上述失败的case中，opt_boundary都是int64，导致防呆报错。后续需要同时兼容int32和int64