Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization] Main CICD pipeline, don't display deploy warning when only synthing #87

Closed
1 of 2 tasks
Cameronsplaze opened this issue Dec 16, 2024 · 1 comment
Closed
1 of 2 tasks
Labels
enhancement New feature or request

Comments

@Cameronsplaze
Copy link
Owner

Is your feature request related to a problem? Please describe.

Just be more clear to users, and what the pipeline is thinking. Displaying a warning that's irrelevant can be confusing.

Describe the solution you'd like

Only show the warning on deploy.

Originally I didn't want to because it adds extra complexity to the setup-matrix.setup-deploy step, BUT I think it'll work out if I just create another step under that one. It can have an output that goes straight to the deploy-base input.

With this, setup-matrix won't just be for matrix's any more. And setup in both the job and step is redundant anyways. Change to something like: setup.synth-matrix, setup.deploy-matrix, and setup.should-deploy. (That final setup.should-deploy has the warning, because at that point it'd have all the variables to know if it should print it or not. Plus that job always runs, so it'd always be checked.)

Describe alternatives you've considered

Leave it as is I guess...

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@Cameronsplaze Cameronsplaze added the enhancement New feature or request label Dec 16, 2024
@Cameronsplaze
Copy link
Owner Author

Poked at it, but too complicated for what it gives. Just leaving the warning as a hint onto get the action to deploy.

(And added a line to help make this a little more clear in the warning at least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant