Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Possible Optimization] Research what the ECS Daemon placement strategy is about #92

Open
1 of 2 tasks
Cameronsplaze opened this issue Jan 10, 2025 · 2 comments
Open
1 of 2 tasks
Labels
enhancement New feature or request

Comments

@Cameronsplaze
Copy link
Owner

Is your feature request related to a problem? Please describe.

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs.Ec2Service.html#daemon

Does it keep the ASG and ECS Task count in sync automatically? I'm pessimistic it'll work, but worth a shot. It'd simplify a solid chunk of the architecture if it does.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@Cameronsplaze Cameronsplaze added the enhancement New feature or request label Jan 10, 2025
@Cameronsplaze
Copy link
Owner Author

Make sure to also set:

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs.Ec2Service.html#minhealthypercent
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs.Ec2Service.html#maxhealthypercent

I'm having to hard-code the defaults to get around the aws/aws-cdk#31705 warning, which for some reason I CAN'T JUST IGNORE... The defaults change if you set daemon though, so we'll want to just keep it in sync

@Cameronsplaze
Copy link
Owner Author

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs_services.html#service_scheduler_daemon

TLDR, it'd let us rip out the ECS placement scheduler strategy stuff at least! But I think we'd still need the three alarms on the task to watch when it fails to spin down the ASG in response. Definitely an improvement, but no not as large of one as I was hoping. (Though it could still be faster to spin up in Daemon mode if it's more optimized behind the scenes?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant