Post audit changes Part 1 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuszx
reviewed
Jul 8, 2024
deuszx
reviewed
Jul 8, 2024
deuszx
approved these changes
Jul 8, 2024
Co-authored-by: deuszx <95355183+deuszx@users.noreply.github.com>
woocash2
reviewed
Jul 8, 2024
ggawryal
approved these changes
Jul 8, 2024
amm/contracts/stable_pool/lib.rs
Outdated
| @@ -718,7 +723,7 @@ pub mod stable_pool { | |||
| let current_time = self.env().block_timestamp(); | |||
| let mut rate_changed = false; | |||
| for rate in self.pool.token_rates.iter_mut() { | |||
| rate_changed = rate_changed || rate.update_rate_no_cache(current_time); | |||
| rate_changed = rate.update_rate_no_cache(current_time) || rate_changed; | |||
There was a problem hiding this comment.
I'd prefer | there anyway, as (1) Using || in expressions used in assignments is usually asking for troubles (someone might fork the repo and add some new condition after rate_changed, which would be bad), and (2) I'm not sure if the gas cost of || wouldn't be greater, because of conditional jumps (probably in nanoscale, but still).
But it's correct and contracts are non-upgradeable, so up to you :P
There was a problem hiding this comment.
I personally like || more than bitwise |
- It's more clear
- When using
|,rate_changedwould have to have a number type (|shouldn't be applicable tobool) and this is weird - Optimization of
|sounds negligible
I can also propose an alternative which is 100% clear 😛
if rate.update_rate_no_cache(current_time) {
rate_changed = true;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of the changes recommended in #22 and #18
DcalculationPrecisionerror whenDcalculation takes more thanMAX_ITERATIONS||used inupdate_rates(...)