Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loans with low health factor chard added #368

Merged
merged 9 commits into from
Jan 25, 2025

Conversation

iamnovichek
Copy link
Collaborator

  1. Reworked chart for Loans with low health factor using data_handler data
  2. Put it in main chart class

@iamnovichek iamnovichek reopened this Jan 21, 2025
@djeck1432 djeck1432 self-requested a review January 21, 2025 17:57
Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use DashboardDataHandler for fetching data instead of fetching data from file

def add_leading_zeros(hash: str) -> str:
"""
Converts e.g. `0x436d8d078de345c11493bd91512eae60cd2713e05bcaa0bb9f0cba90358c6e` to
`0x00436d8d078de345c11493bd91512eae60cd2713e05bcaa0bb9f0cba90358c6e`.
"""
return "0x" + hash[2:].zfill(64)


def load_data(protocol: str) -> tuple[dict[str, pd.DataFrame], pd.DataFrame]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rework this code, we don't need to use it anymore, we will work with DB

Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit d7c068f into master Jan 25, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants