Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total deposit amount per token function #472 #476

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

WillNovus
Copy link
Contributor

@WillNovus WillNovus commented Feb 26, 2025

@djeck1432

The deposit amount per token function is ready. It was designed to iterate the data schema according to the mock data in the guidelines and extract the values of the key 'Collateral' column. I also tested the function across similar data tables extracted from the parquet urls in the legacy notebooks.

https://storage.googleapis.com/derisk-persistent-state/zklend_data/loans.parquet
https://storage.googleapis.com/derisk-persistent-state/nostra_alpha_data/loans.parquet
https://storage.googleapis.com/derisk-persistent-state/nostra_mainnet_data/loans.parquet
https://storage.googleapis.com/derisk-persistent-state/hashstack_v0_data/loans.parquet
https://storage.googleapis.com/derisk-persistent-state/hashstack_v1_data/loans.parquet

Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove chatgpt comments. thank you

Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test with tests/data.csv file?
because It doesn't work with that file

@djeck1432
Copy link
Collaborator

@WillNovus
Copy link
Contributor Author

Hi @djeck1432 If you are able to check out the file attached, it has exactly the same schema as the data file I was asked to use.

I was trying to point out that the Collateral column in the data.csv has a DefaultDict data type with empty values. So there was no way to use it to test the different Tokens with respective amounts.

I have resolved the PR. The prior 'working code' in our DM did not work on the test data sample.

nostra_alpha.csv
https://storage.googleapis.com/derisk-persistent-state/nostra_alpha_data/loans.parquet

@djeck1432
Copy link
Collaborator

@WillNovus yeah, just noticed that, there were 2 test data files, and I removed wrong one

@djeck1432 djeck1432 merged commit f74ddbe into CarmineOptions:master Feb 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard app] Add total amount of deposit
2 participants