-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Total deposit amount per token function #472 #476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove chatgpt comments. thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test with tests/data.csv file?
because It doesn't work with that file
@WillNovus Please, follow task description |
e7ae42d
to
067a1aa
Compare
Hi @djeck1432 If you are able to check out the file attached, it has exactly the same schema as the data file I was asked to use. I was trying to point out that the I have resolved the PR. The prior 'working code' in our DM did not work on the test data sample. nostra_alpha.csv |
@WillNovus yeah, just noticed that, there were 2 test data files, and I removed wrong one |
@djeck1432
The deposit amount per token function is ready. It was designed to iterate the data schema according to the mock data in the guidelines and extract the values of the key 'Collateral' column. I also tested the function across similar data tables extracted from the parquet urls in the legacy notebooks.
https://storage.googleapis.com/derisk-persistent-state/zklend_data/loans.parquet
https://storage.googleapis.com/derisk-persistent-state/nostra_alpha_data/loans.parquet
https://storage.googleapis.com/derisk-persistent-state/nostra_mainnet_data/loans.parquet
https://storage.googleapis.com/derisk-persistent-state/hashstack_v0_data/loans.parquet
https://storage.googleapis.com/derisk-persistent-state/hashstack_v1_data/loans.parquet