Skip to content

Commit 2c5aa6c

Browse files
committed
un-parallel it
1 parent de1185e commit 2c5aa6c

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

ASFAchievementManager/ASFAchievementManager.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ public IReadOnlyCollection<ClientMsgHandler> OnBotSteamHandlersInit([NotNull] Bo
7171
return new HashSet<ClientMsgHandler> { CurrentBotAchievementHandler };
7272
}
7373

74+
//Responses
7475

7576
private static async Task<string> ResponseAchievementList(Bot bot, string appids) {
7677
string[] gameIDs = appids.Split(new[] { ',' }, StringSplitOptions.RemoveEmptyEntries);
@@ -91,9 +92,10 @@ private static async Task<string> ResponseAchievementList(Bot bot, string appids
9192
}
9293

9394
//maybe just do it with foreach? It won't be parallel anyway.
94-
IList<string> results = await Utilities.InParallel(gamesToGetAchievements.Select(game => AchievementHandler.GetAchievements(bot, game))).ConfigureAwait(false);
95-
96-
List<string> responses = new List<string>(results.Where(result => !string.IsNullOrEmpty(result)));
95+
List<string> responses = new List<string>();
96+
foreach (uint appID in gamesToGetAchievements) {
97+
responses.Add(await AchievementHandler.GetAchievements(bot, appID).ConfigureAwait(false));
98+
}
9799

98100
return responses.Count > 0 ? bot.Commands.FormatBotResponse(string.Join(Environment.NewLine, responses)) : null;
99101

0 commit comments

Comments
 (0)