Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to releases does not contain any releases #204

Open
inphobia opened this issue Feb 11, 2024 · 2 comments
Open

link to releases does not contain any releases #204

inphobia opened this issue Feb 11, 2024 · 2 comments

Comments

@inphobia
Copy link

https://github.com/Cellule/dndGenerator/blob/0ca03d806190ba070abd74a43ca784d154331d51/src/Footer.tsx#L71C1-L71C84

heya,
while npcgenerator.com has a link to github releases, there aren't any releases availlable. perhaps you could add a git tag and make that available as a release?

i checked the commit history and it seems 0.5.0 came from this commit; 11f0dd5
with the addemdum of this commit: 1bb0f9f

or perhaps you can just tag master since, as far a i can tell, the version number currently isn't used? (perhaps somewhere in node/npm, dunno how that publishing workflow goes).

guess you'll still need to manually make a release bundle after adding the tag: https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository?tool=webui

and thank you for this wonderfull waste of time, love the funky plot hooks.

@Cellule
Copy link
Owner

Cellule commented Feb 13, 2024

Good point, I forgot we had a link to the Releases page on the footer.
We don't really use releases and there's not much active development at this time, mainly keeping thing up-to-date and running.
I'd like to move to a CHANGELOG.md file instead and likely point to that instead of the Releases page.
I'll try to look into that when I have some time

@inphobia
Copy link
Author

thought i'd give a hand and tag it for you, but can't find a way make a pull request for only a tag.

to retroactively add it you can use:

git tag -a 0.5.0 1bb0f9f027d2487974a9beb88393a09636cd319f
git add .
git commit
git push

this will add a tarball labeled 0.5.0 under https://github.com/Cellule/dndGenerator/tags
... and doesn't completely fix this issue since that's still not https://github.com/Cellule/dndGenerator/releases :)

to fix that you'll need to checkout the above mentioned commit, update footer, add tag, push it to a new branch:
i don't recommend doing this....

git checkout 1bb0f9f027d2487974a9beb88393a09636cd319f -b t050
vi ./src/Footer.tsx
git add .
git commit
git tag -a 0.5.0
git push

perhaps it's easier just to:

your proposal of moving to a changelog solves it as well. imo however, for reference & dependencies a tag or release is easier to work with since it's a fixed point.

whatever works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants