From 4372cf186708785dd456ab210dddf4751f31cf42 Mon Sep 17 00:00:00 2001 From: Oleh Paduchak Date: Fri, 21 Feb 2025 16:39:34 +0200 Subject: [PATCH] fixed resource-reference spam if ther is no resource-reference on backend --- app/packages/addons-service/provider.ts | 6 +++--- .../addon/components/addons-service/manager/component.ts | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/packages/addons-service/provider.ts b/app/packages/addons-service/provider.ts index d9088459b3..602aa683fb 100644 --- a/app/packages/addons-service/provider.ts +++ b/app/packages/addons-service/provider.ts @@ -51,7 +51,7 @@ export default class Provider { @service intl!: Intl; @tracked node?: NodeModel; - @tracked serviceNode?: ResourceReferenceModel; + @tracked serviceNode?: ResourceReferenceModel | null; currentUser: CurrentUserService; @tracked userReference!: UserReferenceModel; @@ -115,7 +115,7 @@ export default class Provider { currentUser: CurrentUserService, node?: NodeModel, allConfiguredAddons?: EmberArray, - resourceReference?: ResourceReferenceModel, + resourceReference?: ResourceReferenceModel | null, userReference?: UserReferenceModel, ) { setOwner(this, getOwner(provider)); @@ -179,7 +179,7 @@ export default class Provider { @task @waitFor async getResourceReference() { - if (this.node && !this.serviceNode) { + if (this.node && this.serviceNode === undefined) { const resourceRefs = await this.store.query('resource-reference', { filter: {resource_uri: this.node.links.iri?.toString()}, }); diff --git a/lib/osf-components/addon/components/addons-service/manager/component.ts b/lib/osf-components/addon/components/addons-service/manager/component.ts index 5f4d7e30bc..db5382e4b4 100644 --- a/lib/osf-components/addon/components/addons-service/manager/component.ts +++ b/lib/osf-components/addon/components/addons-service/manager/component.ts @@ -58,7 +58,7 @@ export default class AddonsServiceManagerComponent extends Component { @service toast!: Toast; node = this.args.node; - @tracked addonServiceNode?: ResourceReferenceModel; + @tracked addonServiceNode?: ResourceReferenceModel | null; @tracked userReference?: UserReferenceModel; possibleFilterTypes = Object.values(FilterTypes); @@ -343,6 +343,8 @@ export default class AddonsServiceManagerComponent extends Component { }); if(references) { this.addonServiceNode = references.firstObject; + } else { + this.addonServiceNode = null; } }