Updates for Yuhuais comments

CenterForOpenScience · Feb 1, 2024 · edfed7d · edfed7d
1 parent be26596
commit edfed7d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/osf-components/addon/components/cedar-metadata-editor/component.ts b/lib/osf-components/addon/components/cedar-metadata-editor/component.ts
@@ -44,12 +44,12 @@ export default class CedarMetadataEditor extends Component<Args> {
             // eslint-disable-next-line
             // @ts-ignore
             this.cedarEmbeddableEditor.instanceObject = this.args.cedarMetadataRecord.metadata;
-            this.changed();
+            this.validateCedarMetadata();
         }
     }
 
     @action
-    changed() {
+    validateCedarMetadata() {
         // eslint-disable-next-line
         // @ts-ignore
         const report = this.cedarEmbeddableEditor.dataQualityReport;
@@ -72,7 +72,7 @@ export default class CedarMetadataEditor extends Component<Args> {
     async save() {
         // This is because you can clear a field without it changing
         // The form can change from valid to invalid
-        this.changed();
+        this.validateCedarMetadata();
         let record: CedarMetadataRecordModel;
         if (this.isEdit) {
             record = this.args.cedarMetadataRecord!;

diff --git a/lib/osf-components/addon/components/cedar-metadata-editor/template.hbs b/lib/osf-components/addon/components/cedar-metadata-editor/template.hbs
@@ -10,7 +10,7 @@
             {{did-insert this.injectMetadata}}
             local-class='cedar-editor'
             config={{this.cedarConfig}}
-            {{ on 'change' (action this.changed) }} 
+            {{ on 'change' (action this.validateCedarMetadata) }} 
             templateObject={{@cedarMetadataTemplate.template}}
         />
     </div>