Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5004][ENG-6968][ENG-6953][ENG-6954][ENG-6955] send usage metrics to datacite #2490

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Jan 24, 2025

Purpose

send usage metrics to datacite

Summary of Changes

  • add @datacite/datacite-tracker dependency
  • track pageviews with datacite (when the resource has a doi)
  • track preprint downloads with datacite

Screenshot(s)

None. Entirely backend changes.

Side Effects

None expected.

QA Notes

Tickets

https://openscience.atlassian.net/browse/ENG-5004 - epic
https://openscience.atlassian.net/browse/ENG-6968 - make this PR
https://openscience.atlassian.net/browse/ENG-6953 - feature
https://openscience.atlassian.net/browse/ENG-6954 - feature
https://openscience.atlassian.net/browse/ENG-6955 - feature

aaxelb and others added 5 commits January 24, 2025 15:08
- add `@datacite/datacite-tracker` dependency
- track pageviews with datacite (when the resource has a doi)
- track preprint downloads with datacite
@aaxelb aaxelb changed the title [ENG-6953][ENG-6954][ENG-6955] send usage metrics to datacite [wip][ENG-6953][ENG-6954][ENG-6955] send usage metrics to datacite Jan 30, 2025
@coveralls
Copy link

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13252009493

Details

  • 13 of 51 (25.49%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.8%) to 74.622%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/models/preprint.ts 2 3 66.67%
lib/osf-components/addon/modifiers/track-download.ts 6 10 60.0%
app/services/analytics.ts 1 34 2.94%
Totals Coverage Status
Change from base Build 13059060187: 7.8%
Covered Lines: 695
Relevant Lines: 889

💛 - Coveralls

futa-ikeda
futa-ikeda previously approved these changes Feb 10, 2025
Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, though I wish I knew what exactly was causing the test to timeout. Percy changes also seemed like random text/image jitter and the addition of new addons workflow snapshots

@aaxelb aaxelb marked this pull request as ready for review February 10, 2025 19:00
@aaxelb aaxelb changed the title [wip][ENG-6953][ENG-6954][ENG-6955] send usage metrics to datacite [ENG-6953][ENG-6954][ENG-6955] send usage metrics to datacite Feb 10, 2025
@felliott felliott changed the title [ENG-6953][ENG-6954][ENG-6955] send usage metrics to datacite [ENG-5004][ENG-6968][ENG-6953][ENG-6954][ENG-6955] send usage metrics to datacite Feb 18, 2025
@felliott felliott self-requested a review February 18, 2025 14:43
Copy link
Member

@felliott felliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants