Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/olehs datacite usage tracker #2496

Open
wants to merge 2 commits into
base: feature/datacite-usage-tracker
Choose a base branch
from

Conversation

opaduchak
Copy link
Contributor

  • Ticket: []
  • Feature flag: n/a

Purpose

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

@opaduchak opaduchak changed the base branch from develop to feature/datacite-usage-tracker January 30, 2025 15:15
@futa-ikeda
Copy link
Contributor

Dang, looking at the build failure, it seems like the build process is looking for vanilla JS and is getting a TS file

Module build failed (from ./node_modules/ember-auto-import/node_modules/babel-loader/lib/index.js):
SyntaxError: /home/runner/work/ember-osf-web/ember-osf-web/node_modules/datacite-tracker/src/index.ts: Missing semicolon. (11:15)

   9 |     if (scriptEl) {
  10 |         // Find the DOI
> 11 |         let doi: string = ""
     |                ^
  12 |
  13 |         // Get DOI from the dataset tag always as preferred
  14 |         doi = scriptEl.dataset.doi || "";

Not sure how hard it would be to address this, but would you mind seeing if it's an easy/stable/reasonable fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants