[ENG-6102] Added context phrase to institutions filter modal on search pages #2514
Conversation
Pull Request Test Coverage Report for Build 13460664502Details
💛 - Coveralls |
| @@ -47,6 +47,10 @@ export default class FilterFacet extends Component<FilterFacetArgs> { | |||
| @tracked filterString = ''; | |||
| @tracked hasMoreValueOptions = false; | |||
| @tracked nextPageCursor = ''; | |||
| @tracked hasDescription = false; | |||
| @tracked description = ''; | |||
| @tracked link_text = ''; | |||
There was a problem hiding this comment.
Very minor suggetion: javascript names are typically camelCase
| this.description = propertyPath[0]?.description?.[0]?.['@value'] || ''; | ||
| this.link_text = propertyPath[0]?.link_text?.[0]?.['@value'] || ''; | ||
| this.link = propertyPath[0]?.link?.[0]?.['@value'] || ''; |
There was a problem hiding this comment.
I believe these can be simplified a little bit by doing
| this.description = propertyPath[0]?.description?.[0]?.['@value'] || ''; | |
| this.link_text = propertyPath[0]?.link_text?.[0]?.['@value'] || ''; | |
| this.link = propertyPath[0]?.link?.[0]?.['@value'] || ''; | |
| import { getSingleOsfmapValue } from 'ember-osf-web/packages/osfmap/jsonld'; | |
| ... | |
| this.description = getSingleOsfmapValue(propertyPath, ['description']) || ''; | |
| this.link_text = getSingleOsfmapValue(propertyPath, ['link_text') || ''; | |
| this.link = getSingleOsfmapValue(propertyPath, ['link']) || ''; |
| {{#if (and this.hasDescription (not this.collapsed))}} | ||
| <Button | ||
| data-analytics-name='See more filterable values {{@property.displayLabel}}' | ||
| data-test-see-more-filterable-values={{@property.displayLabel}} | ||
| @layout='fake-link' | ||
| {{on 'click' this.openSeeMoreModal}} | ||
| > | ||
| {{t 'search.filter-facet.see-more'}} | ||
| </Button> | ||
| {{/if}} |
There was a problem hiding this comment.
I'm not sure if this belongs here. Seems like something extra that was copy-pasted
| {{#if (and this.hasDescription)}} | ||
| {{ this.description }} <a href={{this.link}}> {{ this.link_text }} </a> | ||
| {{else }} | ||
| {{t 'search.filter-facet.see-more-modal-text'}} | ||
| {{/if}} |
There was a problem hiding this comment.
Question: Does the PropertyPath.description field from the SHARE API return the entire phrase "Please select a filter to apply to your search. Only OSF Institutions member affiliations are discoverable."?
Do we want the SHARE API only return "Only OSF Institutions member affiliations..." in the PropertyPath.description field and the FE just shows "Please select a filter to apply to your search." no matter what?
There was a problem hiding this comment.
Yeah, I designed SHARE API to return description to return Please select an institution to apply to your search. Only OSF Institutions member affiliations are discoverable., linkText to return text that represents a link and link itselt.
On the ticket description, the context phrase is different from the current phrase on the Frontend (Please select a filter to apply to your search), so I added the part Please select an institution to apply to your search to the description from SHARE API. I can change the phrases that SHARE API returns if needed.
Purpose
Added context phrase to institutions filter modal on search pages
Summary of Changes
TBD
Screenshot(s)
Side Effects
TBD
QA Notes
TBD