Skip to content

Feature/integrating safari browser #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

Ramyapatil712
Copy link
Collaborator

@Ramyapatil712 Ramyapatil712 commented Mar 5, 2025

Purpose

Updated the selenium test suite to support safari browser local and remote.
Fixed following tests to be executed without error on safari browser:

  • test_collections.py
  • test_dashboard.py
  • test_institutions.py
  • test_landing.py
  • test_login.py
  • test_meetings.py
  • test_metadata.py
  • test_my_projects.py
  • test_my_registrations.py
  • test_navbar.py
  • test_popular_pages.py
  • test_preprints.py
  • test_registration_sidebar.py
  • test_registries.py

Summary of Changes

  1. Updated settings.py to include desired capabilities for safari remote browser
  2. Updated utils.py with a method to clean string objects
  3. Update tests to fix assertion errors and added delays to fix timeout errors

Fixed following tests.

test_landing.py
tests/test_landing.py::TestHomeLandingPage::test_learn_more PASSED
tests/test_landing.py::TestHomeLandingPage::test_testimonials_by_buttons PASSED

test_login.py

In test_login.py fixed following tests:

tests/test_login.py::Test2FAPage::test_need_help_link PASSED
tests/test_login.py::TestToSPage::test_continue_button_disabled PASSED
tests/test_login.py::TestToSPage::test_terms_of_use_link PASSED
tests/test_login.py::TestToSPage::test_privacy_policy_link tests/test_login.py::Test2FAPage::test_cancel_2fa_login PASSED
tests/test_login.py::Test2FAPage::test_need_help_link PASSED
tests/test_login.py::TestToSPage::test_terms_of_use_link PASSED
tests/test_login.py::TestToSPage::test_privacy_policy_link PASSED
tests/test_login.py::TestLoginErrors::test_missing_email PASSED
tests/test_login.py::TestLoginErrors::test_missing_password PASSED

Following tests are still failing due to OAUTH is blocked on safari.

tests/test_login.py::TestOauthAPI::test_authorization_online FAILED tests/test_login.py::TestOauthAPI::test_authorization_offline FAILED
tests/test_login.py::TestOauthAPI::test_authorization_single_scope FAILED

Reviewer's Actions

git fetch <remote> pull/276/head:feature/integrating-safari-browser

Run this test using
pytest tests/test_collections.py -s -v
pytest tests/test_dashboard.py -s -v
pytest tests/test_institutions.py -s -v
pytest tests/test_landing.py -s -v
pytest tests/test_login.py -s -v
pytest tests/test_meetings.py -s -v
pytest tests/test_metadata.py -s -v
pytest tests/test_my_projects.py -s -v
pytest tests/test_my_registrations.py -s -v
pytest tests/test_navbar.py -s -v
pytest tests/test_popular_pages.py -s -v
pytest tests/test_preprints.py -s -v
pytest tests/test_registration_sidebar.py -s -v
pytest tests/test_registries.py -s -v

Change .env file to run tests on safari browser

Testing Changes Moving Forward

Ticket

https://openscience.atlassian.net/browse/ENG-6143
https://openscience.atlassian.net/browse/ENG-6144
https://openscience.atlassian.net/browse/ENG-6145
https://openscience.atlassian.net/browse/ENG-6146
https://openscience.atlassian.net/browse/ENG-7091
https://openscience.atlassian.net/browse/ENG-7717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant