Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Updated the selenium test suite to support safari browser local and remote.
Fixed following tests to be executed without error on safari browser:
Summary of Changes
Fixed following tests.
test_landing.py
tests/test_landing.py::TestHomeLandingPage::test_learn_more PASSED
tests/test_landing.py::TestHomeLandingPage::test_testimonials_by_buttons PASSED
test_login.py
In test_login.py fixed following tests:
tests/test_login.py::Test2FAPage::test_need_help_link PASSED
tests/test_login.py::TestToSPage::test_continue_button_disabled PASSED
tests/test_login.py::TestToSPage::test_terms_of_use_link PASSED
tests/test_login.py::TestToSPage::test_privacy_policy_link tests/test_login.py::Test2FAPage::test_cancel_2fa_login PASSED
tests/test_login.py::Test2FAPage::test_need_help_link PASSED
tests/test_login.py::TestToSPage::test_terms_of_use_link PASSED
tests/test_login.py::TestToSPage::test_privacy_policy_link PASSED
tests/test_login.py::TestLoginErrors::test_missing_email PASSED
tests/test_login.py::TestLoginErrors::test_missing_password PASSED
Following tests are still failing due to OAUTH is blocked on safari.
tests/test_login.py::TestOauthAPI::test_authorization_online FAILED tests/test_login.py::TestOauthAPI::test_authorization_offline FAILED
tests/test_login.py::TestOauthAPI::test_authorization_single_scope FAILED
Reviewer's Actions
git fetch <remote> pull/276/head:feature/integrating-safari-browser
Run this test using
pytest tests/test_collections.py -s -v
pytest tests/test_dashboard.py -s -v
pytest tests/test_institutions.py -s -v
pytest tests/test_landing.py -s -v
pytest tests/test_login.py -s -v
pytest tests/test_meetings.py -s -v
pytest tests/test_metadata.py -s -v
pytest tests/test_my_projects.py -s -v
pytest tests/test_my_registrations.py -s -v
pytest tests/test_navbar.py -s -v
pytest tests/test_popular_pages.py -s -v
pytest tests/test_preprints.py -s -v
pytest tests/test_registration_sidebar.py -s -v
pytest tests/test_registries.py -s -v
Change .env file to run tests on safari browser
Testing Changes Moving Forward
Ticket
https://openscience.atlassian.net/browse/ENG-6143
https://openscience.atlassian.net/browse/ENG-6144
https://openscience.atlassian.net/browse/ENG-6145
https://openscience.atlassian.net/browse/ENG-6146
https://openscience.atlassian.net/browse/ENG-7091
https://openscience.atlassian.net/browse/ENG-7717