feat: AppBar 컴포넌트 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
|
🚀 Storybook 리뷰가 준비되었습니다: |
ptq124
approved these changes
Jan 20, 2025
Comment on lines
+15
to
+19
| <div {...restProps} className={cx(styles.appBar({ variant }), className)}> | ||
| {left && <AppBarElement direction="left">{left}</AppBarElement>} | ||
| {children} | ||
| {right && <AppBarElement direction="right">{right}</AppBarElement>} | ||
| </div> |
There was a problem hiding this comment.
left center right 별로 다 달라서 외부에서 주입하는 거 잘하신거 같아요. AppBarElement를 통해 재사용성을 높인 부분도 좋네요👍
Comment on lines
+5
to
+19
| base: { | ||
| position: 'relative', | ||
| height: 44, | ||
| display: 'flex', | ||
| alignItems: 'center', | ||
| maxWidth: 440, | ||
| }, | ||
| variants: { | ||
| variant: { | ||
| default: [ | ||
| typography('title_1_22_b'), | ||
| { | ||
| padding: '0 10px 0 20px', | ||
| }, | ||
| ], |
There was a problem hiding this comment.
리뷰 보고 css 코드 보니까 px을 안붙여도 가능하네요. 동환님 방식이 더 편한거 같습니다.
padding: '0 10px 0 20px', padding 부분은 px을 붙여야지 작동하나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
작업한 목록을 작성해 주세요
스크린샷
pr 포인트나 궁금한 점을 작성해 주세요
연관된 issue: #6