Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 레이아웃 수정, eslint 수정, 라우터 추가 #35

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Conversation

DongjaJ
Copy link
Collaborator

@DongjaJ DongjaJ commented Jan 21, 2025

이슈 번호

작업한 목록을 작성해 주세요

  • 레이아웃을 깔끔하게 수정했습니다
  • 라우터를 추가했습니다
  • eslint에서 import시 파일 확장자를 입력하는 룰을 제거하고 반영했습니다.

스크린샷

pr 포인트나 궁금한 점을 작성해 주세요

  • 헤더가 필요한 페이지는 홈, 헤더가 필요 없는 페이지는 로그인 페이지를 참고하면 좋을 것 같습니다
  • 추후 인증이 필요한 페이지를 가드하는 로직도 필요할 것 같지만 지금은 작업하지 않았습니다.

@DongjaJ DongjaJ requested a review from ptq124 as a code owner January 21, 2025 05:40
@DongjaJ DongjaJ linked an issue Jan 21, 2025 that may be closed by this pull request
1 task
Copy link

Copy link
Collaborator

@ptq124 ptq124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

Comment on lines +26 to +31
<Route element={<BottomNavigationLayout />}>
<Route path="home" element={<HomePage />} />
<Route path="pillbox" element={<PillboxPage />} />
<Route path="consultation" element={<ConsultationPage />} />
<Route path="mypage" element={<MyPage />} />
</Route>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bottom Navigation 쓰는것 만 모아 놓은거 좋은거 같아요. 이러면 개발하기 쉽겠네요!

@DongjaJ DongjaJ merged commit 8bd8675 into main Jan 21, 2025
11 checks passed
@DongjaJ DongjaJ deleted the feat-20 branch January 21, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: router 설정
2 participants