Skip to content

Commit 0b61ee9

Browse files
authored
Merge pull request #78 from ChainSafe/irubido/removeDemoWallet
removed demo wallet, updated readme
2 parents ab26297 + 9296571 commit 0b61ee9

40 files changed

+41
-2488
lines changed

.github/workflows/deploy-demo.yml

Lines changed: 0 additions & 51 deletions
This file was deleted.

.gitignore

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ dist
1717
.idea
1818
.vscode
1919

20-
# Demo Wallet package
21-
packages/demo-wallet/dist/*
22-
!/packages/demo-wallet/dist/_headers
23-
2420
# e2e Tests package
2521
packages/e2e-tests/dist/*
2622
!/packages/e2e-tests/dist/serve.json

README.md

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ This just script uses wasm-pack to build a web-ready copy of `webzjs-wallet` and
7272
just build
7373
```
7474

75-
### Building and running the demo-wallet
76-
7775
#### Prerequisites
7876

7977
[Install yarn](https://yarnpkg.com/getting-started/install)
@@ -89,26 +87,27 @@ just build
8987
Install js dependencies with
9088

9189
```shell
92-
yarn i
90+
yarn
9391
```
9492

95-
Build the demo wallet with
93+
## Development
94+
95+
### Building and running WebZjs Zcash Snap locally
9696

9797
```shell
98+
cd packages/snap
9899
yarn build
100+
yarn serve
99101
```
100102

101-
Serve it with
103+
### Building and running WebZjs Web-wallet locally
102104

103105
```shell
104-
yarn serve
106+
cd packages/web-wallet
107+
yarn build
108+
yarn dev
105109
```
106110

107-
> [!IMPORTANT]
108-
> For unknown reasons it is currently not possible to use the parcel dev server to serve the demo-wallet hence the build and then serve steps
109-
110-
## Development
111-
112111
### Testing
113112

114113
Browser tests are run in a headless browser environment and can be run with
@@ -119,7 +118,7 @@ just test-web
119118

120119
## Known Issues
121120

122-
You might notice the demo-wallet builds using parcel despite being configured to use Vite for development. This is due to a [known issue](https://github.com/vitejs/vite/issues/7015) with vite where it cannot correctly handle what it deems to be a cyclic dependency introduced by `wasm_bindgen_rayon` webworkers. Other bundlers tested to not seem to be affected.
121+
123122

124123
## Security Warnings
125124

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515
"packageManager": "yarn@4.5.1",
1616
"scripts": {
1717
"dev": "yarn workspace @chainsafe/webzjs-web-wallet run dev & yarn run snap:start",
18-
"demo-wallet:serve": "yarn workspace @chainsafe/webzjs-demo-wallet run serve",
19-
"demo-wallet:dev": "yarn run just:build-keys && yarn run snap:start & yarn run web-wallet:dev",
20-
"demo-wallet:build": "yarn workspace @chainsafe/webzjs-demo-wallet run build",
2118
"web-wallet:dev": "yarn workspace @chainsafe/webzjs-web-wallet run dev & yarn run snap:start",
2219
"web-wallet:build": "yarn workspace @chainsafe/webzjs-web-wallet run build",
2320
"test:e2e": "yarn workspace @chainsafe/webzjs-e2e-tests test",

packages/demo-wallet/.env

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/demo-wallet/.gitignore

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/demo-wallet/README.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/demo-wallet/index.html

Lines changed: 0 additions & 11 deletions
This file was deleted.

packages/demo-wallet/package.json

Lines changed: 0 additions & 39 deletions
This file was deleted.

packages/demo-wallet/src/App/Actions.tsx

Lines changed: 0 additions & 193 deletions
This file was deleted.

0 commit comments

Comments
 (0)