Skip to content

Commit ad1e6ce

Browse files
authored
fix: remove change:multiaddrs listener (#387)
1 parent e2e1009 commit ad1e6ce

File tree

1 file changed

+1
-35
lines changed

1 file changed

+1
-35
lines changed

src/index.ts

+1-35
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ import { InboundStream, OutboundStream } from './stream.js'
7878
import { Uint8ArrayList } from 'uint8arraylist'
7979
import { decodeRpc, DecodeRPCLimits, defaultDecodeRpcLimits } from './message/decodeRpc.js'
8080
import { ConnectionManager } from '@libp2p/interface-connection-manager'
81-
import { PeerMultiaddrsChangeData, PeerStore } from '@libp2p/interface-peer-store'
81+
import { PeerStore } from '@libp2p/interface-peer-store'
8282
import { Multiaddr } from '@multiformats/multiaddr'
8383
import { multiaddrToIPStr } from './utils/multiaddr.js'
8484

@@ -590,8 +590,6 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements PubSub<G
590590
const heartbeatTimeout = setTimeout(this.runHeartbeat, constants.GossipsubHeartbeatInitialDelay)
591591
// Then, run heartbeat every `heartbeatInterval` offset by `GossipsubHeartbeatInitialDelay`
592592

593-
this.components.peerStore.addEventListener('change:multiaddrs', this.onPeerAddressChange)
594-
595593
this.status = {
596594
code: GossipStatusCode.started,
597595
registrarTopologyIds,
@@ -628,8 +626,6 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements PubSub<G
628626
const { registrarTopologyIds } = this.status
629627
this.status = { code: GossipStatusCode.stopped }
630628

631-
this.components.peerStore.removeEventListener('change:multiaddrs', this.onPeerAddressChange)
632-
633629
// unregister protocol and handlers
634630
const registrar = this.components.registrar
635631
registrarTopologyIds.forEach((id) => registrar.unregister(id))
@@ -879,36 +875,6 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements PubSub<G
879875
this.acceptFromWhitelist.delete(id)
880876
}
881877

882-
private onPeerAddressChange = (evt: CustomEvent<PeerMultiaddrsChangeData>): void => {
883-
const { peerId, multiaddrs, oldMultiaddrs } = evt.detail
884-
const newIps = new Set<string>()
885-
const oldIps = new Set<string>()
886-
for (const mu of multiaddrs) {
887-
const ipStr = multiaddrToIPStr(mu)
888-
if (ipStr) {
889-
newIps.add(ipStr)
890-
}
891-
}
892-
for (const mu of oldMultiaddrs) {
893-
const ipStr = multiaddrToIPStr(mu)
894-
if (ipStr) {
895-
// Remove multiaddrs that aren't new
896-
if (newIps.has(ipStr)) {
897-
newIps.delete(ipStr)
898-
} else {
899-
oldIps.add(ipStr)
900-
}
901-
}
902-
}
903-
const id = peerId.toString()
904-
for (const ipStr of oldIps) {
905-
this.score.removeIP(id, ipStr)
906-
}
907-
for (const ipStr of newIps) {
908-
this.score.addIP(id, ipStr)
909-
}
910-
}
911-
912878
// API METHODS
913879

914880
get started(): boolean {

0 commit comments

Comments
 (0)