Filter out bitswap providers before picking random provider

Author: pyropy

lib/spark.js

@@ -249,11 +249,24 @@ export default class Spark {
       return
     }
 
-    const randomProvider = pickRandomProvider(alternativeProviders, randomness)
-    if (!randomProvider) {
+    const validAlternativeProviders = alternativeProviders.filter(
+      (p) => p.protocol !== 'bitswap',
+    )
+
+    if (!validAlternativeProviders.length) {
       console.warn(
         'No providers serving the content via HTTP or Graphsync found. Skipping network-wide retrieval check.',
       )
+    }
+
+    const randomProvider = pickRandomProvider(
+      validAlternativeProviders,
+      randomness,
+    )
+    if (!randomProvider) {
+      console.warn(
+        'Failed to pick a random provider. Skipping network-wide retrieval check.',
+      )
       return
     }
 
@@ -507,8 +520,8 @@ export function pickRandomProvider(providers, randomness) {
     return items[Math.floor(rng.next() * items.length)]
   }
 
-  const providersWithPieceInfoContextID = providers.filter(
-    (p) => p.contextId.startsWith('ghsA') && p.protocol !== 'bitswap',
+  const providersWithPieceInfoContextID = providers.filter((p) =>
+    p.contextId.startsWith('ghsA'),
   )
 
   // Priority 1: HTTP providers with ContextID containing PieceCID