fix: retry IPNI queries on 5xx errors #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
commented
Mar 27, 2025
juliangruber
approved these changes
Mar 27, 2025
| console.log('IPNI returned %s provider results', providerResults.length) | ||
| } catch (err) { | ||
| console.error('IPNI query failed.', err) | ||
| return { indexerResult: 'ERROR_FETCH' } | ||
| return { | ||
| indexerResult: typeof err.statusCode === 'number' ? `ERROR_${err.statusCode}` : 'ERROR_FETCH' |
There was a problem hiding this comment.
Suggested change
| indexerResult: typeof err.statusCode === 'number' ? `ERROR_${err.statusCode}` : 'ERROR_FETCH' | |
| indexerResult: typeof err.status === 'number' ? `ERROR_${err.status}` : 'ERROR_FETCH' |
https://developer.mozilla.org/en-US/docs/Web/API/Response/status
There was a problem hiding this comment.
Oh I see, this is the error from assertOkResponse, not fetch. Nevermind
| @@ -100,7 +99,8 @@ export default class Spark { | |||
| controller.abort() | |||
| }, 60_000) | |||
| } | |||
| maxDurationTimeout = setTimeout(() => { | |||
|
|
|||
| const maxDurationTimeout = setTimeout(() => { | |||
There was a problem hiding this comment.
You are welcome. It was reported by npx standard. I am surprised this passed our CI checks 🤔
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npx standardLinks: