Skip to content

ci: run CI for community-contributed pull requests #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 2, 2025
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Mar 31, 2025

Ensure we run CI for community-contributed pull requests (see #127 (review)).

  • "on push" to "main"
  • "on pull request" targeting any branch

This is the same configuration we already have in piece-indexer, see CheckerNetwork/piece-indexer#8

- "on push" to "main"
- "on pull request" targeting "main"

This is the same configuration we already have in spark-evaluate.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos changed the title ci: run CI for all changes targetting main branch ci: run CI for all changes targetting main branch + standalone linting job Mar 31, 2025
bajtos added 2 commits March 31, 2025 14:54
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
Copy link
Member Author

bajtos commented Mar 31, 2025

Strangely enough, the first commit did not reproduce the npx standard linting problem observed when running standard locally. I extracted more changes from #127 (added two more commits). The standalone lint step is still passing 🤔

@bajtos
Copy link
Member Author

bajtos commented Mar 31, 2025

Oh, I see that I have already fixed the linting errors in #126 🤦🏻

This PR is ready for review & landing.

@bajtos bajtos marked this pull request as ready for review March 31, 2025 12:58
@bajtos bajtos requested a review from juliangruber as a code owner March 31, 2025 12:58
@bajtos
Copy link
Member Author

bajtos commented Mar 31, 2025

Screenshot 2025-03-31 at 15 13 54

I'll update the branch protection rules after this PR is approved (but before landing).

@bajtos bajtos requested a review from juliangruber March 31, 2025 15:09
@bajtos bajtos changed the title ci: run CI for all changes targetting main branch + standalone linting job ci: run CI for all changes targetting main branch + a standalone linting job Apr 1, 2025
@bajtos bajtos changed the title ci: run CI for all changes targetting main branch + a standalone linting job ci: run CI for all changes targetting main branch Apr 1, 2025
@bajtos
Copy link
Member Author

bajtos commented Apr 1, 2025

I removed all other changes to keep this PR smaller in scope & independent of #127.

@bajtos
Copy link
Member Author

bajtos commented Apr 1, 2025

@juliangruber LGTY now?

@bajtos bajtos changed the title ci: run CI for all changes targetting main branch ci: run CI for community-contributed pull requests Apr 2, 2025
@bajtos bajtos merged commit b98b08c into main Apr 2, 2025
5 checks passed
@bajtos bajtos deleted the fix-ci-lint branch April 2, 2025 11:11
@github-project-automation github-project-automation bot moved this to ✅ done in Space Meridian Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

2 participants