Skip to content

chore: remove reward tracking logic #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

pyropy
Copy link
Contributor

@pyropy pyropy commented Jun 12, 2025

This pull request removes the functionality related to calculating and submitting participant reward scores during the evaluation process.

Core functionality changes:

  • Removed the setScores parameter and logic from the evaluate function, including all calculations for participant rewards and rounding adjustments. [1] [2] [3]

Test updates:

  • Removed all test cases and assertions related to setScores, including scenarios for reward calculations, dummy entries for rounding, and majority measurements. Simplified the test suite to focus on the remaining evaluation functionality. [1] [2] [3] [4] [5]

Closes #573

@pyropy pyropy marked this pull request as ready for review June 20, 2025 09:37
@pyropy pyropy changed the title WIP: chore: remove rewards chore: remove rewards Jun 20, 2025
@pyropy pyropy self-assigned this Jun 20, 2025
@pyropy pyropy changed the title chore: remove rewards chore: remove reward tracking logic Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Remove Rewards Logic from Spark Evaluate
1 participant