core: Remove fraud detection logic #572
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyropy
requested review from
bajtos,
juliangruber and
NikolasHaimerl
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the evaluation process in
lib/evaluate.jsby removing therunFraudDetectionfunction and replacing it with a streamlined approach for grouping and evaluating measurements. By removing the fraud detection all measurements are marked as valid and are accepted by the evaluation mechanism. It also updates related telemetry and test cases to reflect these changes.Simplifications in Evaluation Logic:
runFraudDetectionfunction and replaced it with an inline implementation that directly processes measurements marking them as valid using a generator function (iterateAcceptedMeasurements) to avoid array duplication. (lib/evaluate.js, [1] [2] [3]REQUIRED_COMMITTEE_SIZEfrom 30 to 1. (lib/evaluate.js, lib/evaluate.jsL3-R12)Updates to Telemetry:
fraud_detection_duration_msandretrieval_stats_honest, consolidating all retrieval stats underretrieval_stats_all. (lib/evaluate.js, [1] [2]Test Case Adjustments:
test/evaluate.jsto reflect the removal ofrunFraudDetectionand the consolidation of telemetry points. This includes changes to expected telemetry data and test descriptions. (test/evaluate.js, [1] [2] [3] [4] [5]Blocked by #569
Closes #574