Field mask validation

Author: FabioBatSilva

php/ext/google/protobuf/php-upb.c

@@ -2526,14 +2526,14 @@ static void jsonenc_fieldpath(jsonenc* e, upb_StringView path) {
   while (ptr < end) {
     char ch = *ptr;
 
-    if (ch >= 'A' && ch <= 'Z') {
-      jsonenc_err(e, "Field mask element may not have upper-case letter.");
-    } else if (ch == '_') {
-      if (ptr == end - 1 || *(ptr + 1) < 'a' || *(ptr + 1) > 'z') {
-        jsonenc_err(e, "Underscore must be followed by a lowercase letter.");
-      }
-      ch = *++ptr - 32;
-    }
+    // if (ch >= 'A' && ch <= 'Z') {
+    //   jsonenc_err(e, "Field mask element may not have upper-case letter.");
+    // } else if (ch == '_') {
+    //   if (ptr == end - 1 || *(ptr + 1) < 'a' || *(ptr + 1) > 'z') {
+    //     jsonenc_err(e, "Underscore must be followed by a lowercase letter.");
+    //   }
+    //   ch = *++ptr - 32;
+    // }
 
     jsonenc_putbytes(e, &ch, 1);
     ptr++;

php/tests/field_mask_test.php

@@ -0,0 +1,16 @@
+<?php
+
+require_once (dirname(__DIR__) . '/vendor/autoload.php');
+require_once (__DIR__ . '/test_util.php');
+
+use Google\Protobuf\FieldMask;
+
+$m1 = new FieldMask();
+$m2 = new FieldMask();
+
+$m1->setPaths(['phoneNumber', 'emailAddress']);
+
+$m2->mergeFromJsonString($m1->serializeToJsonString());
+
+var_dump($m2->getPaths());
+var_dump($m2->serializeToJsonString());