-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace yarn with pnpm #6898
base: develop
Are you sure you want to change the base?
replace yarn with pnpm #6898
Conversation
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is obfuscated code?Obfuscated files are intentionally packed to hide their behavior. This could be a sign of malware. Packages should not obfuscate their code. Consider not using packages with obfuscated code. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
This comment was marked as outdated.
This comment was marked as outdated.
Hi and thanks for the PR, Unfortunately we don't plan to move away from |
Acknowledged. If you think I can lend a hand with any of that, feel free to link any relevant tasks in this PR. |
Description
what's done
yarn.lock
replaced with top-levelpnpm-lock.yaml
postinstall
in top-level package no longer neededworkspaces
key inpackage.json
replaced withpnpm-workspace.yml
ng
command is invokedpnpm
installs shell wrappers innode_modules/.bin
in place of js entrypointsdependencies
of each module specified usingworkspace:*
instead of depending on top-level hoistingyarn.lock
(scary!) brought them out of there and into the appropriatepackage.json
sworkspace:*
version identifiers are pnpm-only"private": true
this doesnt matter in practicenode_modules
) may take some more specific version config but i assume for now it's a non-goal?what's left
process
polyfill to client?package.json
dependencies
/devDependencies
providedRelated issues
Has this been tested?
acceptance criterion:
pnpm i --frozen-lockfile && pnpm test
pass