Skip to content

Commit

Permalink
SASS Dev cleanup (#7273)
Browse files Browse the repository at this point in the history
# Description & Issue number it closes 
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. -->
- move to grunt-contrib-sass 
- Update imports -
https://sass-lang.com/documentation/breaking-changes/import/

## Screenshots (if appropriate)
<!-- Before and after --> 
To address the following 
```

Running "sass:dist" (sass) task
Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api

Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

   ╷
29 │ @import 'scss/dropdowns';
   │         ^^^^^^^^^^^^^^^^
   ╵
    src/skin/churchcrm.scss 29:9  root stylesheet

Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

   ╷
30 │ @import 'scss/forms';
   │         ^^^^^^^^^^^^
   ╵
    src/skin/churchcrm.scss 30:9  root stylesheet


```

## How to test the changes?

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

# How Has This Been Tested?

<!-- Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce. Please also list any relevant
details for your test configuration -->

# Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
  • Loading branch information
DawoudIO authored Feb 23, 2025
2 parents dce74f5 + c37e790 commit 8e7319e
Show file tree
Hide file tree
Showing 5 changed files with 254 additions and 106 deletions.
11 changes: 3 additions & 8 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ module.exports = function (grunt) {

var datatTablesVer = "1.10.18";

const sass = require("sass");

// Project configuration.
grunt.initConfig({
package: grunt.file.readJSON("package.json"),
Expand Down Expand Up @@ -340,11 +338,6 @@ module.exports = function (grunt) {
},
},
sass: {
options: {
implementation: sass,
sourceMap: true,
cacheLocation: process.env["HOME"] + "/node_cache",
},
dist: {
files: {
"src/skin/churchcrm.min.css": "src/skin/churchcrm.scss",
Expand Down Expand Up @@ -698,7 +691,9 @@ module.exports = function (grunt) {
// display local master's commit hash
});

grunt.loadNpmTasks("grunt-sass");
grunt.registerTask('default', ['sass']);

grunt.loadNpmTasks('grunt-contrib-sass');
grunt.loadNpmTasks("grunt-contrib-copy");
grunt.loadNpmTasks("grunt-contrib-clean");
grunt.loadNpmTasks("grunt-contrib-compress");
Expand Down
Loading

0 comments on commit 8e7319e

Please sign in to comment.