Remove Menu.php

[DAcodedBEAT]

Description & Issue number it closes

Back in version 4.2.3, there was an effort to remove the old Menu.php landing page and replace it with a new v2/dashboard. Since this was new and the previous developer wanted to ensure a clean migration, they added gutted the old Menu page and made it a redirect.

Now that an ample amount of time has passed since this change, it should be safe to remove the old Menu.php and exclusively rely on v2/dashboard.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

[DAcodedBEAT]

@DawoudIO feel free to merge this whenever

[MrClever]

Given the amount of time since 4.2.3 was dropped and the fact we have been using the v2/dashboard extensively elsewhere, this looks fine to me.

it might be worth creating a utility function that we can use to reduce the code duplication which is simply called by these pages:
'''
use some/util/thing; // maybe ‘AuthenticationManager’?
…
UserVerification(AuthenticationManager::getCurrentUser()->isRoleEnabled);
'''
The ‘UserVerification’ function takes the Boolean it is passed and simply decides on redirection to (dashboard currently) or not. That way, we can have a single point to manage what happens when someone hits a page they shouldn’t be on.