Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up dependency injection container for setup routes #6821

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

DAcodedBEAT
Copy link
Contributor

Description & Issue number it closes

Setup routes were broken, see #6819 for details

How to test the changes?

Delete src/Include/Config.php and run through the setup.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@DAcodedBEAT DAcodedBEAT added bug Installation / Upgrade php Pull requests that update Php code labels Jan 17, 2024
@DAcodedBEAT DAcodedBEAT added this to the 5.5.0 milestone Jan 17, 2024
@DawoudIO DawoudIO merged commit 4d8a8db into master Jan 17, 2024
1 check passed
@DawoudIO DawoudIO deleted the fix-setup-routes branch January 17, 2024 02:54
Copy link
Collaborator

@MrClever MrClever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will need to test a full “fresh” install for future…this wont show up for imported data and pre-configured deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Installation / Upgrade php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants