2 bug problem saving from familyeditor #6834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Fix to FamilyEditor save problem, Issue #6833
Currently this just adjusts the quoting on the NULL references so that the SQL is properly formed. This is done on 3 fields.
No Screenshots
How to test the changes?
Prior to this fix, attempting to edit and save family info (FamilyEditor) with a blank for info on Latitude, Longitude, or Wedding Date, would result in a server error due to malformed SQL. After this fix, any or all of those fields should be able to be blank.
Type of change
How Has This Been Tested?
Tested via editing a family, and leaving the above referenced fields blank, then trying to save. The SQL error no longer occurs, but now there is a new Slim Application error related to getting photo thumbnail. Details of this error have been added to #6833. Since saving the family info is still not possible, I suggest the fixes for the Slim Application error be corrected within this same Issue/Pull Request. Those changes have not yet been tracked down, but I'm initiating this pull request early to get feedback, and to allow others to try to recreate the new problem and possibly offer suggestions. If it is desired to close this PR and open a new issue/PR for the Slim Application error, then this PR could be merged, and a new issue created.
Checklist: