Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 bug problem saving from familyeditor #6834

Merged

Conversation

grayeul
Copy link
Contributor

@grayeul grayeul commented Jan 26, 2024

Partial Fix to FamilyEditor save problem, Issue #6833

Currently this just adjusts the quoting on the NULL references so that the SQL is properly formed. This is done on 3 fields.

No Screenshots

How to test the changes?

Prior to this fix, attempting to edit and save family info (FamilyEditor) with a blank for info on Latitude, Longitude, or Wedding Date, would result in a server error due to malformed SQL. After this fix, any or all of those fields should be able to be blank.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested via editing a family, and leaving the above referenced fields blank, then trying to save. The SQL error no longer occurs, but now there is a new Slim Application error related to getting photo thumbnail. Details of this error have been added to #6833. Since saving the family info is still not possible, I suggest the fixes for the Slim Application error be corrected within this same Issue/Pull Request. Those changes have not yet been tracked down, but I'm initiating this pull request early to get feedback, and to allow others to try to recreate the new problem and possibly offer suggestions. If it is desired to close this PR and open a new issue/PR for the Slim Application error, then this PR could be merged, and a new issue created.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@DAcodedBEAT DAcodedBEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incremental improvement so I'm okay with merging this as-is, and we can approach permissions checking elsewhere 👍

@DAcodedBEAT DAcodedBEAT merged commit 0000079 into ChurchCRM:master Jan 29, 2024
2 of 3 checks passed
@DAcodedBEAT DAcodedBEAT added this to the vNext milestone Jan 31, 2024
@DAcodedBEAT DAcodedBEAT added bug php Pull requests that update Php code labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants