adding xdebug to the test docker just run url with ?XDEBUG_SESSION_START=1 and wait on port 9003

[TiagoMRodrigues]

…ART=1 and wait on port 9003

Description & Issue number it closes

Screenshots (if appropriate)

How to test the changes?

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[DAcodedBEAT]

I don't think Xdebug should be in the test image since this is intended for running the CI tests as quickly as possible.

This change probably makes sense in the dev image though, so it can be used during local development

[DAcodedBEAT]

I think you can set a docker-compose override with the following configuration:

     extra_hosts:
       - host.docker.internal:host-gateway

so your linux machine can also respond to host.docker.internal

[DAcodedBEAT]

I think we should definitely consider the test vs dev image distinction.

Also since this a new feature to the development environment, it might be a good idea to document this somewhere

[TiagoMRodrigues]

sure, didn't notice dev and test were there make all the sense to me that it should be in the other one.
seems to work at least in linux don't have a really a way to test in windows.

I just use this with php debug on vsc
with this config on it

        {
            "name": "XDEBUG ON DOCKER",
            "type": "php",
            "request": "launch",
            "port": 9003,
            "pathMappings": {
                "/var/www/html": "${workspaceFolder}"
            }
      }

[TiagoMRodrigues]

@DawoudIO can you help in here this should not make any difference.

[DawoudIO]

I don't use the dev docket, just the test one. If you think this is useful and has no bad affect go for it

[TiagoMRodrigues]

Any idea why this keep failing on ui/finance/finance.reports.spec.js ? didn't even touch the test docker only the dev one all the code is the same as the one that is passing on master

[DawoudIO]

I'll habe to checkout the branch and do some testing or you can run the test manually via cypress ui

[DAcodedBEAT]

Why were files removed in 2da1090 ?

[TiagoMRodrigues]

git commit -am added the files in Image folder and I just recommited without them again instead of going backwards.

[TiagoMRodrigues]

added by mistake on c122ce5

[DAcodedBEAT]

added by mistake on c122ce5

@TiagoMRodrigues I think these files already existed, but you changed the permissions on these files, which caused it to show in the diff.

[TiagoMRodrigues]

yes you are right will revert on it.