Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rector] apply SetList::DEAD_CODE, better type checking (see description for breakdown) #7011

Merged
merged 22 commits into from
Aug 9, 2024
Merged

[rector] apply SetList::DEAD_CODE, better type checking (see description for breakdown) #7011

merged 22 commits into from
Aug 9, 2024

Conversation

DAcodedBEAT
Copy link
Contributor

This commit includes a variety of changes that improve the codebase's quality and consistency. The following changes were made:

  • Replaced == with === for strict comparisons.
  • Removed redundant break statements after return in switch-case structures.
  • Fixed variable naming consistency and unnecessary variable assignments.
  • Simplified conditional statements and removed unused code.
  • Corrected minor typos and formatted code for better readability.
  • Enhanced type safety by casting variables explicitly and adding type hints.
  • Improved function and variable documentation with consistent comments.
  • Refactored repeated logic to improve maintainability.
  • Removed redundant checks for null values and unnecessary extractions.

@DAcodedBEAT DAcodedBEAT added Code Smell php Pull requests that update Php code labels May 8, 2024
@DAcodedBEAT DAcodedBEAT requested a review from a team as a code owner May 8, 2024 04:51
@DAcodedBEAT DAcodedBEAT requested review from respencer, DawoudIO, grayeul and MrClever and removed request for a team May 8, 2024 04:51
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.9.0) milestone May 8, 2024
@DAcodedBEAT DAcodedBEAT marked this pull request as draft May 8, 2024 06:20
respencer
respencer reviewed May 8, 2024
View reviewed changes
@DAcodedBEAT
Copy link
Contributor Author

@respencer if you have any free time, feel free to pull this down and see if anything is any more broken than how things are currently

@respencer
Copy link
Contributor

@respencer if you have any free time, feel free to pull this down and see if anything is any more broken than how things are currently

I'm constantly finding things that are broken. We shouldn't continue to add to this PR though.

What's an acceptable middle ground for you?

@DAcodedBEAT
Copy link
Contributor Author

@respencer if you have any free time, feel free to pull this down and see if anything is any more broken than how things are currently

I'm constantly finding things that are broken. We shouldn't continue to add to this PR though.

What's an acceptable middle ground for you?

@respencer I'm thinking we can merge this after the current release finally gets cut.

@respencer
Copy link
Contributor

I still have a few things to add, but there's some wonky changes I want to track down the cause of before continuing.

@DAcodedBEAT DAcodedBEAT force-pushed the rector-cleanup branch 2 times, most recently from 23e29dd to f9d0e23 Compare May 28, 2024 04:02
@DAcodedBEAT DAcodedBEAT marked this pull request as ready for review June 13, 2024 04:45
@DAcodedBEAT
Copy link
Contributor Author

Holding this until rectorphp/rector-src#5964 gets released and then I'll rerun

@DawoudIO DawoudIO modified the milestones: 5.9.0, vNext (5.10.0) Jun 15, 2024
@DAcodedBEAT DAcodedBEAT marked this pull request as ready for review August 9, 2024 03:18
DAcodedBEAT and others added 22 commits August 8, 2024 23:18
@DAcodedBEAT
[rector] apply SetList::DEAD_CODE, better type checking (see msg)
4f06bc2 
This commit includes a variety of changes that improve the codebase's quality and consistency. The following changes were made:

- Replaced `==` with `===` for strict comparisons.
- Removed redundant `break` statements after `return` in switch-case structures.
- Fixed variable naming consistency and unnecessary variable assignments.
- Simplified conditional statements and removed unused code.
- Corrected minor typos and formatted code for better readability.
- Enhanced type safety by casting variables explicitly and adding type hints.
- Improved function and variable documentation with consistent comments.
- Refactored repeated logic to improve maintainability.
- Removed redundant checks for null values and unnecessary extractions.

functions
@DAcodedBEAT
add back $vows since it's used via variable variables
71d5bd4
@DAcodedBEAT
uppercase start of docblock comment
068eec3
@respencer @DAcodedBEAT
Clean up comments and add logger
e6bbf45 
Also deleted unused monthCounter variable.
@DawoudIO @DAcodedBEAT
Apply fixes from StyleCI
bbf7172
@respencer @DAcodedBEAT
Fix for rector const delete
a24ae1e
@DAcodedBEAT
fix the fix for deleted const from rector by using it properly
b17cf0e
@DAcodedBEAT
remove union type in return
a09678a
@DAcodedBEAT
[rector] apply SetList::DEAD_CODE, better type checking (see msg)
7bd1efa 
This commit includes a variety of changes that improve the codebase's quality and consistency. The following changes were made:

- Replaced `==` with `===` for strict comparisons.
- Removed redundant `break` statements after `return` in switch-case structures.
- Fixed variable naming consistency and unnecessary variable assignments.
- Simplified conditional statements and removed unused code.
- Corrected minor typos and formatted code for better readability.
- Enhanced type safety by casting variables explicitly and adding type hints.
- Improved function and variable documentation with consistent comments.
- Refactored repeated logic to improve maintainability.
- Removed redundant checks for null values and unnecessary extractions.
@DAcodedBEAT
fix discrepencies with Person address usage
4762332
@DAcodedBEAT
rename variable to for clarity
6bc52e7
@DAcodedBEAT
make assembleYearMonthDay logic clearer
f439f54
@DAcodedBEAT
remove unused GetGroupArray.php file
6f43190
@DAcodedBEAT
remove calls to unnecessary BaseSearchResultProvider constructor
863d469
@DAcodedBEAT
fix issues reported from phpstan
80d95fc
@DAcodedBEAT
find and fix issues from codebase
ee88155
@DAcodedBEAT
fix typeerror in PrintFYIDSelect
61cfe8c
@DAcodedBEAT
phpcs optionmanager
a435a96
@DAcodedBEAT
fix invalid legacyFilterInput type in PledgeEditor
7e5e140
@DAcodedBEAT
add more types and rerun rector
77e530e
@DAcodedBEAT
add back $vows since it's used via variable variables
114b830
@DAcodedBEAT
update rector and re-process
30d74c7
@DAcodedBEAT
Copy link
Contributor Author

@respencer / @DawoudIO this has been rebased and is ready to go

@DAcodedBEAT DAcodedBEAT modified the milestones: vNext (5.11.0), 5.10.0 Aug 9, 2024
@DAcodedBEAT DAcodedBEAT merged commit 630f148 into master Aug 9, 2024
6 checks passed
@DAcodedBEAT DAcodedBEAT deleted the rector-cleanup branch August 9, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@respencer respencer respencer approved these changes

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees
No one assigned
Labels
Code Smell php Pull requests that update Php code
Projects
None yet
Milestone
5.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DAcodedBEAT @respencer @DawoudIO