Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix php deprecation notice in Countries #7015

Merged
merged 1 commit into from
May 8, 2024

Conversation

DAcodedBEAT
Copy link
Contributor

@DAcodedBEAT DAcodedBEAT commented May 8, 2024

This resolves the issue shown below:

PHP Deprecated:  Use of "static" in callables is deprecated in develop/ChurchCRM/src/ChurchCRM/data/Countries.php on line 280

Deprecated: Use of "static" in callables is deprecated in develop/ChurchCRM/src/ChurchCRM/data/Countries.php on line 280

Description & Issue number it closes

Screenshots (if appropriate)

How to test the changes?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

This resolves the issue shown below:
```
PHP Deprecated:  Use of "static" in callables is deprecated in develop/ChurchCRM/src/ChurchCRM/data/Countries.php on line 280

Deprecated: Use of "static" in callables is deprecated in develop/ChurchCRM/src/ChurchCRM/data/Countries.php on line 280
```
@DAcodedBEAT DAcodedBEAT requested a review from a team as a code owner May 8, 2024 07:30
@DAcodedBEAT DAcodedBEAT requested review from respencer, DawoudIO, grayeul and MrClever and removed request for a team May 8, 2024 07:30
@DAcodedBEAT DAcodedBEAT added Code Smell php Pull requests that update Php code labels May 8, 2024
Copy link
Contributor

@respencer respencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DAcodedBEAT DAcodedBEAT merged commit 75082a2 into master May 8, 2024
4 checks passed
@DAcodedBEAT DAcodedBEAT deleted the countries-php-deprecation branch May 8, 2024 08:01
@DAcodedBEAT DAcodedBEAT added this to the Current (5.8.0) milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Smell php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants