Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused canvass feature #7067

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

respencer
Copy link
Contributor

Description & Issue number it closes

The canvass feature has missing database entries going back 20 years.

I don't see any open or closed issues about it, and a quick poll on Gitter showed no one was using it.

Screenshots (if appropriate)

None.

How to test the changes?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer respencer force-pushed the remove-unused-canvass branch from 6384479 to 7ce6520 Compare June 10, 2024 13:18
@respencer respencer marked this pull request as ready for review June 10, 2024 13:18
@respencer respencer requested a review from a team as a code owner June 10, 2024 13:18
@respencer respencer requested review from DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team June 10, 2024 13:18
@respencer respencer force-pushed the remove-unused-canvass branch 2 times, most recently from 1da31cc to a2f64d4 Compare June 12, 2024 13:12
@DAcodedBEAT DAcodedBEAT added php Pull requests that update Php code Code Smell labels Jun 12, 2024
@DAcodedBEAT
Copy link
Contributor

@respencer As a fast follow, can you go through the wiki and remove the references to the canvass feature?

@respencer
Copy link
Contributor Author

@respencer As a fast follow, can you go through the wiki and remove the references to the canvass feature?

I'm part way through totally redoing the wiki, I just haven't pushed anything yet.

Will add this to my todo list for the wiki.

@respencer respencer force-pushed the remove-unused-canvass branch from a2f64d4 to 0f7c7d7 Compare June 12, 2024 13:20
@DAcodedBEAT
Copy link
Contributor

@respencer As a fast follow, can you go through the wiki and remove the references to the canvass feature?

I'm part way through totally redoing the wiki, I just haven't pushed anything yet.

Will add this to my todo list for the wiki.

Awesome! I'm planning on merging this once the tests are done, so we should remove this soon after to avoid having documentation for a nonexistent feature

@DAcodedBEAT DAcodedBEAT merged commit 17e502a into ChurchCRM:master Jun 12, 2024
3 checks passed
@DAcodedBEAT DAcodedBEAT added this to the 5.9.0 milestone Jun 12, 2024
@DawoudIO
Copy link
Contributor

You need to update the

"current" : {
to support 5.9.0 (I think we yet to move the version of the software) and also the demo/ChurchCRM-Database.sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Smell php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants