Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added English - Jamaica & English - South Africa locales #7090

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Conversation

DawoudIO
Copy link
Contributor

@DawoudIO DawoudIO commented Jul 13, 2024

Description & Issue number it closes

  • Added English - English - South Africa locale
  • Added English - South Africa locale

Screenshots (if appropriate)

image
image
image

How to test the changes?

  • update user locale in settings

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

run npm run locale-download and npm run deploy to download locale and rebuild UI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DawoudIO DawoudIO added this to the vNext (5.10.0) milestone Jul 13, 2024
@DawoudIO DawoudIO requested a review from a team as a code owner July 13, 2024 22:16
@DawoudIO DawoudIO requested review from respencer, grayeul, DAcodedBEAT and MrClever and removed request for a team July 13, 2024 22:16
@DawoudIO DawoudIO merged commit 5902648 into master Jul 16, 2024
6 checks passed
@DawoudIO DawoudIO deleted the loacle/en-xx branch July 16, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant