Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Fix DataTable options of GroupView #7170

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

bigtigerku
Copy link
Contributor

@bigtigerku bigtigerku commented Sep 28, 2024

Description & Issue number it closes

There was a typo.

Screenshots (if appropriate)

Change Page Length Setting to 25

Screenshot 2024-09-27 at 7 20 36 PM

Group View displays 10 entries

Screenshot 2024-09-27 at 7 21 17 PM

After fix, it displays correct entries

Screenshot 2024-09-27 at 7 21 32 PM

How to test the changes?

See the above screenshots

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bigtigerku bigtigerku requested a review from a team as a code owner September 28, 2024 02:29
@bigtigerku bigtigerku requested review from respencer, DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team September 28, 2024 02:29
Copy link
Contributor

@DawoudIO DawoudIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed only place where the case used is window.CRM.plugin.DataTable

@DawoudIO DawoudIO merged commit 60db139 into ChurchCRM:master Sep 28, 2024
5 checks passed
@DawoudIO DawoudIO added this to the vNext (5.10.1) milestone Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants