Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS Dev cleanup #7273

Merged
merged 1 commit into from
Feb 23, 2025
Merged

SASS Dev cleanup #7273

merged 1 commit into from
Feb 23, 2025

Conversation

DawoudIO
Copy link
Contributor

Description & Issue number it closes

Screenshots (if appropriate)

To address the following


Running "sass:dist" (sass) task
Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api

Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

   ╷
29 │ @import 'scss/dropdowns';
   │         ^^^^^^^^^^^^^^^^
   ╵
    src/skin/churchcrm.scss 29:9  root stylesheet

Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

   ╷
30 │ @import 'scss/forms';
   │         ^^^^^^^^^^^^
   ╵
    src/skin/churchcrm.scss 30:9  root stylesheet


How to test the changes?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DawoudIO DawoudIO added the build label Feb 22, 2025
@DawoudIO DawoudIO requested a review from a team as a code owner February 22, 2025 23:58
@DawoudIO DawoudIO requested review from respencer, grayeul, DAcodedBEAT, MrClever and bigtigerku and removed request for a team February 22, 2025 23:58
@DawoudIO DawoudIO added this to the 5.15.0 milestone Feb 22, 2025
@DawoudIO DawoudIO merged commit 8e7319e into master Feb 23, 2025
8 checks passed
@DawoudIO DawoudIO deleted the build/sass-upgrade branch February 23, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant