Added ndo_fabric_span_session module for the Fabric Monitoring Access Policy template (DCNE-138) #656
+1,674
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajagana
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
samiib
requested changes
Apr 22, 2025
sajagana
force-pushed
the
464_fabric_span_session
branch
from
a57bc07 to
704233d
Compare
akinross
requested changes
Apr 25, 2025
anvitha-jain
requested changes
May 1, 2025
| type: str | ||
| template_id: | ||
| description: | ||
| - The ID of the that contains the destination port channel. |
There was a problem hiding this comment.
This sentence is incomplete, also extra space between the and that
sajagana
dismissed stale reviews from anvitha-jain, samiib, shrsr, akinross, and gmicol
via
179e8d2
sajagana
force-pushed
the
464_fabric_span_session
branch
from
17f2b7c to
179e8d2
Compare
lhercot
requested changes
May 7, 2025
| type: str | ||
| source_ip_prefix: | ||
| description: | ||
| - The destination IP address prefix to route SPAN Session packets. |
There was a problem hiding this comment.
Suggested change
| - The destination IP address prefix to route SPAN Session packets. | |
| - The prefix used to assign source IP addresses to ERSPAN packets which can be used to identify which Leaf or Spine is sending the traffic. | |
| - This can be any IP. If the prefix is used, the node ID of the source node is used for the undefined bits of the prefix. |
| suboptions: | ||
| node: | ||
| description: | ||
| - The Node ID to use for the SPAN Session. |
There was a problem hiding this comment.
Suggested change
| - The Node ID to use for the SPAN Session. | |
| - The Node ID of the Node to use for the SPAN Session. |
| - The Node ID to use for the SPAN Session. | ||
| type: int | ||
| required: true | ||
| path: |
There was a problem hiding this comment.
Suggested change
| path: | |
| interface: |
| required: true | ||
| path: | ||
| description: | ||
| - The Node Ethernet interface to use for the SPAN Session. |
There was a problem hiding this comment.
Suggested change
| - The Node Ethernet interface to use for the SPAN Session. | |
| - The Ethernet interface of the Node to use for the SPAN Session. |
…nitoring Access Policy template
…ite_interface_details function logic
…dated ndo_fabric_span_session task names
…estination_port.interface and updated documentation
sajagana
force-pushed
the
464_fabric_span_session
branch
from
179e8d2 to
d816241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.