Skip to content

[minor_change] Add resources and datasources for multisite translation mapping classes fvSiteAssociated and fvRemoteId (DCNE-190) #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[minor_change] Add resources and datasources for multisite translation mapping classes fvSiteAssociated and fvRemoteId (DCNE-190) #1321

wants to merge 3 commits into from

Conversation

akinross
Copy link
Collaborator

fixes #1224

@github-actions github-actions bot changed the title [minor_change] Add resources and datasources for multisite translation mapping classes fvSiteAssociated and fvRemoteId [minor_change] Add resources and datasources for multisite translation mapping classes fvSiteAssociated and fvRemoteId (DCNE-190) Mar 18, 2025
@akinross akinross force-pushed the 1224_site_association branch from 469ce31 to 8269c2b Compare March 20, 2025 09:40
@lhercot lhercot mentioned this pull request Mar 20, 2025
Closed
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.36628% with 248 lines in your changes missing coverage. Please review.

Project coverage is 86.61%. Comparing base (63f3d21) to head (fc125f2).
Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
internal/provider/resource_aci_associated_site.go 86.70% 98 Missing and 36 partials ⚠️
internal/provider/resource_aci_remote_site.go 84.84% 67 Missing and 25 partials ⚠️
...ternal/provider/data_source_aci_associated_site.go 94.66% 9 Missing and 2 partials ⚠️
internal/provider/data_source_aci_remote_site.go 92.02% 9 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
- Coverage   86.64%   86.61%   -0.03%     
==========================================
  Files         133      149      +16     
  Lines       76831    84097    +7266     
==========================================
+ Hits        66569    72842    +6273     
- Misses       8198     8954     +756     
- Partials     2064     2301     +237

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmicol
gmicol previously approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but rebase is required.

@akinross akinross dismissed stale reviews from shrsr and gmicol via 34a9fdd April 2, 2025 06:01
@akinross akinross force-pushed the 1224_site_association branch from 8269c2b to 34a9fdd Compare April 2, 2025 06:01
@shrsr shrsr requested review from gmicol and shrsr April 2, 2025 15:43
shrsr
shrsr previously approved these changes Apr 2, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Apr 2, 2025
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross dismissed stale reviews from anvitha-jain and shrsr via 772c01e April 4, 2025 15:36
@akinross akinross force-pushed the 1224_site_association branch from 34a9fdd to 772c01e Compare April 4, 2025 15:36
anvitha-jain
anvitha-jain approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr shrsr self-requested a review April 4, 2025 18:26
@akinross akinross force-pushed the 1224_site_association branch from 772c01e to 8d33fb9 Compare April 5, 2025 03:04
sajagana
sajagana previously approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrsr
shrsr previously approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot requested a review from anvitha-jain April 7, 2025 20:45
anvitha-jain
anvitha-jain previously approved these changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross dismissed stale reviews from anvitha-jain, gmicol, sajagana, shrsr, and samiib via fc125f2 April 25, 2025 08:43
@akinross akinross force-pushed the 1224_site_association branch from 0aeb4eb to fc125f2 Compare April 25, 2025 08:43
gmicol
gmicol previously approved these changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

anvitha-jain
anvitha-jain previously approved these changes Apr 29, 2025
View reviewed changes
@akinross akinross dismissed stale reviews from anvitha-jain, sajagana, samiib, and gmicol via b030602 April 30, 2025 10:03
@akinross akinross force-pushed the 1224_site_association branch from fc125f2 to b030602 Compare April 30, 2025 10:03
gmicol
gmicol approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrsr shrsr shrsr approved these changes

@samiib samiib samiib approved these changes

@gmicol gmicol gmicol approved these changes

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add resource and datasource for fvSiteAssociated and fvRemoteId (DCNE-190)
8 participants
@akinross @codecov-commenter @lhercot @shrsr @anvitha-jain @sajagana @samiib @gmicol