-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(php): better usage/explanation of PHP_INI_SCAN_DIR usage to load FPM values in CLI #527
Merged
juliamrch
merged 5 commits into
CleverCloud:main
from
Yoda-BZH:php-better-php_ini_scan_dir-usage
Feb 20, 2025
Merged
feat(php): better usage/explanation of PHP_INI_SCAN_DIR usage to load FPM values in CLI #527
juliamrch
merged 5 commits into
CleverCloud:main
from
Yoda-BZH:php-better-php_ini_scan_dir-usage
Feb 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋` Review app deletedYou closed this PR and deleted the review app. |
FPM .user.ini file in CLI
f249021
to
1a8e371
Compare
juliamrch
previously approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced passive voice by active voice.
Thank you so much for this update!
juliamrch
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR
By default, PHP-CLI does not load PHP-FPM
.user.ini
files. The documentation about loading this file was a bit obscure/complicated.This explanation may be a bit clearer/simpler
Checklist
Reviewers
Who should review these changes? @juliamrch