-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview web custom html #358
Open
rohitniyerclevertap
wants to merge
18
commits into
develop
Choose a base branch
from
preview-web-custom-html
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1f8dfcd
testing web native display
rohitniyerclevertap ba27c12
testing post message
rohitniyerclevertap 05bbab5
added check on window.opener
rohitniyerclevertap 3842e23
Merge branch 'search-params' of github.com:CleverTap/clevertap-web-sd…
rohitniyerclevertap e7d0003
Added post message proxy code
rohitniyerclevertap 6c89a3a
testing post message
rohitniyerclevertap 78f0948
testing
rohitniyerclevertap 0472091
testing
rohitniyerclevertap 771d5ea
testing
rohitniyerclevertap dfa56f2
testing
rohitniyerclevertap 2fcb52c
testing
rohitniyerclevertap fd68b5e
testing
rohitniyerclevertap 0af7dec
Removed consoles
rohitniyerclevertap 3ae66c0
REmoved prcoess element function
rohitniyerclevertap 91f49ee
Changed message for 1st handshake to ready
rohitniyerclevertap 9b359d1
Merge branch 'develop' of github.com:CleverTap/clevertap-web-sdk into…
rohitniyerclevertap 98ab394
PR comments addressed
rohitniyerclevertap b9ec8b1
Added version bump and change log
rohitniyerclevertap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the details about the changes in PR Template.
Changelog and version bump is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please squash the commits into 2-3 meaningful commits to avoid rebasing issues for fellow collaborators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will squash the commits and add change log and version bump before merging the PR to develop as I don't know when to merge this